On Thu, 15 Mar 2018 10:57:26 +
Daniel Stone wrote:
> On 14 February 2018 at 12:38, Pekka Paalanen wrote:
> > SEGV and ABRT by default cause a core dump, which may create a file,
> > launch crash handlers, and so on. sanity-test has 21 processes that
> > are expected to crash like this. Disab
On 14 February 2018 at 12:38, Pekka Paalanen wrote:
> SEGV and ABRT by default cause a core dump, which may create a file,
> launch crash handlers, and so on. sanity-test has 21 processes that
> are expected to crash like this. Disable core dumps on them all.
>
> I counted 21 entries in coredumpct
On 2018-02-26 03:44 AM, Pekka Paalanen wrote:
From: Pekka Paalanen
Commit e501230d1dc8a5015616e104ec0e08886a0b88df "scanner: Fix broken
private-code generation" changed the scanner output without updating the
reference output for scanner tests.
Update the reference data. This fixes 'make check
From: Pekka Paalanen
Commit e501230d1dc8a5015616e104ec0e08886a0b88df "scanner: Fix broken
private-code generation" changed the scanner output without updating the
reference output for scanner tests.
Update the reference data. This fixes 'make check'.
Signed-off-by: Pekka Paalanen
---
tests/da
On Wed, 21 Feb 2018 13:08:51 -0600
Derek Foreman wrote:
> For years it's been common practice to free the object containing
> the wl_listner inside resource destruction notifiers, but not
> remove the listener from the list.
>
> That is: It's been safe to assume that the wl_listener will never b
For years it's been common practice to free the object containing
the wl_listner inside resource destruction notifiers, but not
remove the listener from the list.
That is: It's been safe to assume that the wl_listener will never be
touched again, since this is a destruction callback.
Recently som
From: Pekka Paalanen
SEGV and ABRT by default cause a core dump, which may create a file,
launch crash handlers, and so on. sanity-test has 21 processes that
are expected to crash like this. Disable core dumps on them all.
I counted 21 entries in coredumpctl list, while only 16 functions needed
On 19 January 2018 at 17:37, Derek Foreman wrote:
> In f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the
> repository, but not to the distribution.
Oops. :(
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
wayland-devel mailing list
wayla
In f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the
repository, but not to the distribution.
Signed-off-by: Derek Foreman
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index bceca2a..01ad805 100644
--- a/Makefile.am
+++ b/Makefile.
Hi Yong,
On 23 November 2016 at 15:38, Yong Bakos wrote:
> connection-test.c did not cover wl_argument_from_va_list, so add one
> test that specifically tests this method.
Easy enough, reviewed and pushed:
To ssh://git.freedesktop.org/git/wayland/wayland
de908658..8fe8a2bb push -> master
Th
On Mon, 23 Jan 2017 11:49:24 -0600
Derek Foreman wrote:
> Tests that the compositor is prevented from sending a resource id
> from one client in an event to another client.
>
> This tests the (rare in practice) subset of the problem where both
> clients magically happen to have the same kind of
Tests that the compositor is prevented from sending a resource id
from one client in an event to another client.
This tests the (rare in practice) subset of the problem where both
clients magically happen to have the same kind of object with the
same id, so the client has no way to know it's being
From: Yong Bakos
connection-test.c did not cover wl_argument_from_va_list, so add one
test that specifically tests this method.
Signed-off-by: Yong Bakos
---
tests/connection-test.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/tests/connection-test.c
On Fri, 11 Nov 2016 07:08:09 -0800
Yong Bakos wrote:
> From: Yong Bakos
>
> Array argument symbols in a wl_message may be nullable, but the test for
> wl_message_count_arrays did not test this. Add one more wl_message with
> nullable array arguments.
>
> Signed-off-by: Yong Bakos
> ---
> tes
From: Yong Bakos
Array argument symbols in a wl_message may be nullable, but the test for
wl_message_count_arrays did not test this. Add one more wl_message with
nullable array arguments.
Signed-off-by: Yong Bakos
---
tests/message-test.c | 6 --
1 file changed, 4 insertions(+), 2 deletion
On Thu, 3 Nov 2016 13:42:54 -0700
Yong Bakos wrote:
> From: Yong Bakos
>
> message-test.c did not cover wl_message_count_arrays, so add one test that
> specifically tests this method. Note that this exposes wl_message_count_arrays
> in a private header (wayland-private.h), and removes the `sta
On Thu, 10 Nov 2016 11:14:03 +
Daniel Stone wrote:
> Rather than using a hardcoded 'wayland-tests' directory under
> the existing XDG_RUNTIME_DIR to use as the new runtime dir, use mkdtemp
> to guarantee uniqueness. This fixes make -jN check, as well as just
> happen
Rather than using a hardcoded 'wayland-tests' directory under
the existing XDG_RUNTIME_DIR to use as the new runtime dir, use mkdtemp
to guarantee uniqueness. This fixes make -jN check, as well as just
happening to run 'make check' twice from the same session.
Signed-
From: Yong Bakos
The test suite did not cover wl_interface_equal, so add one test that
specifically tests this method. Add the new test to Makefile.am.
Signed-off-by: Yong Bakos
---
Makefile.am| 3 +++
tests/interface-test.c | 49 +
From: Yong Bakos
message-test.c did not cover wl_message_count_arrays, so add one test that
specifically tests this method. Note that this exposes wl_message_count_arrays
in a private header (wayland-private.h), and removes the `static` modifier of
the implementation.
Signed-off-by: Yong Bakos
2016-11-01 18:49 GMT+01:00 Yong Bakos :
> On Nov 1, 2016, at 10:35 AM, Giulio Camuffo wrote:
>>
>> Hi,
>>
>> I think i would put more messages in the array, just two seems like
>> it's not really testing much. Besides that it looks good.
>>
>>
>> Cheers,
>> Giulio
>
> Thanks Giulio, I'll add some
On Nov 1, 2016, at 10:35 AM, Giulio Camuffo wrote:
>
> Hi,
>
> I think i would put more messages in the array, just two seems like
> it's not really testing much. Besides that it looks good.
>
>
> Cheers,
> Giulio
Thanks Giulio, I'll add some more. My main concern (hence the RFC)
is about ABI
Hi,
I think i would put more messages in the array, just two seems like
it's not really testing much. Besides that it looks good.
Cheers,
Giulio
2016-10-27 17:58 GMT+02:00 Yong Bakos :
> From: Yong Bakos
>
> message-test.c did not cover wl_message_count_arrays, so add one test that
> specifica
From: Yong Bakos
message-test.c did not cover wl_message_count_arrays, so add one test that
specifically tests this method. Note that this exposes wl_message_count_arrays
in a private header (wayland-private.h), and removes the `static` modifier of
the implementation.
Signed-off-by: Yong Bakos
On Thu, May 19, 2016 at 10:27:29AM -0600, Yong Bakos wrote:
> From: Yong Bakos
>
> The purpose of wayland-*-protocol-core.h is to mimc the
> wayland-*-protocol.h generated by scanner --include-core-only.
> The only difference being what wayland-*-protocol.h should include.
>
> Add an include che
From: Yong Bakos
The purpose of wayland-*-protocol-core.h is to mimc the
wayland-*-protocol.h generated by scanner --include-core-only.
The only difference being what wayland-*-protocol.h should include.
Add an include check in the headers-protocol-core-test, to be sure that
a wayland-*-protocol
*interface, uint32_t
> > > >version)
> > > >+{
> > > >+ bool *tested = data;
> > > >+struct wl_shm *shm;
> > > >+int fd, ret;
> > > >+struct wl_shm_pool *pool;
> > > >+
> > > >+
On Mon, 22 Feb 2016 13:25:33 -0800
Bryce Harrington wrote:
> On Mon, Feb 22, 2016 at 02:37:00PM +0100, Marek Chalupa wrote:
> > test if receiving an error on already destroyed object won't
> > do any harm
> >
> > Signed-off-by: Marek Chalupa
>
> Confirmed that this test catches the error tha
On Mon, Feb 22, 2016 at 02:37:00PM +0100, Marek Chalupa wrote:
> test if receiving an error on already destroyed object won't
> do any harm
>
> Signed-off-by: Marek Chalupa
Reviewed-by: Jonas Ådahl
> ---
> tests/display-test.c | 50 ++
> 1 file
OTHERWISE, ARISING FROM, OUT OF OR IN
> > >+ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> > >+ * SOFTWARE.
> > >+ */
> > >+
> > >+#include
> > >+#include
> > >+#include
> > >+#include
> > >+#include
+#include "test-compositor.h"
> >+
> >+static void
> >+registry_handle_global(void *data, struct wl_registry *registry,
> >+ uint32_t id, const char *interface, uint32_t version)
> >+{
> >+bool *tested = data;
> >+struct wl_shm
On Mon, Feb 22, 2016 at 02:37:00PM +0100, Marek Chalupa wrote:
> test if receiving an error on already destroyed object won't
> do any harm
>
> Signed-off-by: Marek Chalupa
Confirmed that this test catches the error that is fixed by
https://patchwork.freedesktop.org/patch/74577/, and that the te
id, &wl_shm_interface, 1);
+ assert(shm);
+
+ fd = syscall(__NR_memfd_create, "wayland-tests", MFD_CLOEXEC);
memfd_create is rather new syscall, I think that this test won't compile
on older systems. Shouldn't we guard it somehow? For example:
https://g
test if receiving an error on already destroyed object won't
do any harm
Signed-off-by: Marek Chalupa
---
tests/display-test.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/tests/display-test.c b/tests/display-test.c
index 1a6c345..f9f816
, uint32_t version)
+{
+ bool *tested = data;
+ struct wl_shm *shm;
+ int fd, ret;
+ struct wl_shm_pool *pool;
+
+ if (strcmp (interface, "wl_shm"))
+ return;
+
+ shm = wl_registry_bind(registry, id, &wl_shm_interface, 1);
+ asser
Add a test that confirms that proxy versions are always 0 for display
and correct otherwise.
Signed-off-by: Derek Foreman
---
Changes from v1:
Make the global once at a high version, bind it with different versions
create a wl_pointer from the wl_seat to test version inheritance
also test the g
On Wed, 20 May 2015 15:47:00 -0700
Bill Spitzak wrote:
> Please don't duplicate the functions in multiple headers!
>
> You could achieve the same result this way so that there is only one
> copy of each function in the headers:
>
> wayland-client-protocol-core.h =
>(the same as you have it
On Wed, 20 May 2015 22:38:53 +0300
Giulio Camuffo wrote:
> This test checks that the protocol and library headers include only what
> they are supposed to include. That is, that the core headers do not
> include the protocol headers and that the core protocol headers do not
> include the non core
Please don't duplicate the functions in multiple headers!
You could achieve the same result this way so that there is only one
copy of each function in the headers:
wayland-client-protocol-core.h =
(the same as you have it, generated by wayland-scanner -c)
wayland-client-protocol.h =
#inc
This test checks that the protocol and library headers include only what
they are supposed to include. That is, that the core headers do not
include the protocol headers and that the core protocol headers do not
include the non core library headers.
The build process now generates core protocol hea
On 4 December 2014 at 12:12, Pekka Paalanen wrote:
> On Wed, 3 Dec 2014 11:44:47 +0100
> Marek Chalupa wrote:
>
> > On 1 December 2014 at 11:42, Pekka Paalanen wrote:
> >
> > > On Fri, 21 Nov 2014 11:18:33 +0100
> > > Marek Chalupa wrote:
> > >
> > > > We didn't free the struct client that we
On Wed, 3 Dec 2014 11:44:47 +0100
Marek Chalupa wrote:
> On 1 December 2014 at 11:42, Pekka Paalanen wrote:
>
> > On Fri, 21 Nov 2014 11:18:33 +0100
> > Marek Chalupa wrote:
> >
> > > We didn't free the struct client that we got from client_connect()
> > >
> > > Signed-off-by: Marek Chalupa
>
On 1 December 2014 at 11:42, Pekka Paalanen wrote:
> On Fri, 21 Nov 2014 11:18:33 +0100
> Marek Chalupa wrote:
>
> > We didn't free the struct client that we got from client_connect()
> >
> > Signed-off-by: Marek Chalupa
> > ---
> > tests/display-test.c| 23 +--
> > tes
On Fri, 21 Nov 2014 11:18:33 +0100
Marek Chalupa wrote:
> We didn't free the struct client that we got from client_connect()
>
> Signed-off-by: Marek Chalupa
> ---
> tests/display-test.c| 23 +--
> tests/test-compositor.c | 1 +
> 2 files changed, 14 insertions(+), 10
On Fri, 21 Nov 2014 11:15:24 +0100
Marek Chalupa wrote:
> All the test-cases are in one test atm. It doesn't matter for the
> outcome, but when it is split to more tests, the debugging and reading
> the output is simpler.
>
> Signed-off-by: Marek Chalupa
> ---
> tests/queue-test.c | 20 +++
On Fri, 28 Nov 2014 13:09:59 +0100
Marek Chalupa wrote:
> Hi,
>
> Here it is used to suppress the timeout, which just kills the client during
> debugging if you forget to turn it off.
> Since it is just a way how to workaround forgetting of humans (read: me xD)
> I think that I don't care about
Hi,
Here it is used to suppress the timeout, which just kills the client during
debugging if you forget to turn it off.
Since it is just a way how to workaround forgetting of humans (read: me xD)
I think that I don't care about this patch much.
If no-one else want this, I'm OK with rejecting this
On Wed, 19 Nov 2014 12:20:31 +0100
Marek Chalupa wrote:
> Copy function from libinput/test/litest.c is_debugger_detached()
> and use it in our test-runner. If debugger is attached, turn off
> leak checks and timeouts automatically.
>
> Revision of libinput: 028513a0a723e97941c39c4aeb174331987239
On 11/26/2014 06:25 AM, Marek Chalupa wrote:
On 20 November 2014 at 23:59, Bryce Harrington mailto:br...@osg.samsung.com>> wrote:
On Wed, Nov 19, 2014 at 12:00:10PM +0100, Marek Chalupa wrote:
> This env variable is used for turning off the leak checks in tests.
> Rename it to WA
On 20 November 2014 at 23:59, Bryce Harrington
wrote:
> On Wed, Nov 19, 2014 at 12:00:10PM +0100, Marek Chalupa wrote:
> > This env variable is used for turning off the leak checks in tests.
> > Rename it to WAYLAND_TESTS_NO_LEAK_CHECK, so that it is consistent
> > with WAYLAND_TESTS_NO_TIMEOUTS.
We didn't free the struct client that we got from client_connect()
Signed-off-by: Marek Chalupa
---
tests/display-test.c| 23 +--
tests/test-compositor.c | 1 +
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/tests/display-test.c b/tests/display-test.c
i
All the test-cases are in one test atm. It doesn't matter for the
outcome, but when it is split to more tests, the debugging and reading
the output is simpler.
Signed-off-by: Marek Chalupa
---
tests/queue-test.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --g
On Wed, Nov 19, 2014 at 12:00:10PM +0100, Marek Chalupa wrote:
> This env variable is used for turning off the leak checks in tests.
> Rename it to WAYLAND_TESTS_NO_LEAK_CHECK, so that it is consistent
> with WAYLAND_TESTS_NO_TIMEOUTS.
Should these both be 'WAYLAND_TEST_'? In weston there is alre
On Wed, 19 Nov 2014 11:58:26 +0100
Marek Chalupa wrote:
> print "" (which results in no output) instead of
> printing '\0' (which is not visible, but is there)
>
> Signed-off-by: Marek Chalupa
> ---
> tests/test-runner.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --g
Copy function from libinput/test/litest.c is_debugger_detached()
and use it in our test-runner. If debugger is attached, turn off
leak checks and timeouts automatically.
Revision of libinput: 028513a0a723e97941c39c4aeb17433198723913
Signed-off-by: Marek Chalupa
---
tests/test-runner.c | 43
This env variable is used for turning off the leak checks in tests.
Rename it to WAYLAND_TESTS_NO_LEAK_CHECK, so that it is consistent
with WAYLAND_TESTS_NO_TIMEOUTS.
Signed-off-by: Marek Chalupa
---
tests/test-runner.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test
print "" (which results in no output) instead of
printing '\0' (which is not visible, but is there)
Signed-off-by: Marek Chalupa
---
tests/test-runner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-runner.c b/tests/test-runner.c
index a6c75a9..1373225 100644
Oh, yes, sure.
Thanks,
Marek
On 17 November 2014 16:02, Pekka Paalanen wrote:
> On Wed, 12 Nov 2014 13:16:42 +0100
> Marek Chalupa wrote:
>
> > Add test_set_timeout() function that allows the test to
> > set timeout for its completition. Any other call to the function
> > re-sets the timeout t
On Wed, 12 Nov 2014 13:16:42 +0100
Marek Chalupa wrote:
> Add test_set_timeout() function that allows the test to
> set timeout for its completition. Any other call to the function
> re-sets the timeout to the new value. The timeouts can be turned off
> (usefull when debugging) by setting evironm
Add test_set_timeout() function that allows the test to
set timeout for its completition. Any other call to the function
re-sets the timeout to the new value. The timeouts can be turned off
(usefull when debugging) by setting evironment variable
WAYLAND_TESTS_NO_TIMEOUTS.
v2:
rename NO_TIMEOUTS
On Fri, 7 Nov 2014 21:37:28 +0200
Giulio Camuffo wrote:
> Looks good to me, and it doesn't seem to break any test. ;)
>
> Reviewed-by: Giulio Camuffo
Yup, pushed.
Thanks,
pq
> 2014-09-24 15:07 GMT+03:00 Marek Chalupa :
> > Use $XDG_RUNTIME_DIR/wayland-tests for test
Looks good to me, and it doesn't seem to break any test. ;)
Reviewed-by: Giulio Camuffo
2014-09-24 15:07 GMT+03:00 Marek Chalupa :
> Use $XDG_RUNTIME_DIR/wayland-tests for tests. This way we won't be
> messing XDG_RUNTIME_DIR and it also fixes a bug, when socket-test
>
Use $XDG_RUNTIME_DIR/wayland-tests for tests. This way we won't be
messing XDG_RUNTIME_DIR and it also fixes a bug, when socket-test
failed when another compositor was running.
Signed-off-by: Marek Chalupa
---
tests/test-runner.c | 52
1
On Mon, Jan 6, 2014 at 8:34 AM, Mariusz Ceier wrote:
> I think both patches (and original code too obviously) are wrong -
> WL_DISPLAY_ERROR (opcode 0) event has signature "ous", so Quentin
> patch calls event with too many arguments and ignores types, and Marek
> patch calls event with too few ar
I think both patches (and original code too obviously) are wrong -
WL_DISPLAY_ERROR (opcode 0) event has signature "ous", so Quentin
patch calls event with too many arguments and ignores types, and Marek
patch calls event with too few arguments and incorrect type for the
second argument.
Imo, corre
The call is wrong, I posted it here:
http://lists.freedesktop.org/archives/wayland-devel/2013-November/012141.html
But without any reaction. Good that somobody else renewed it :)
On 05/01/2014, Quentin Glidic wrote:
> From: Quentin Glidic
>
> Signed-off-by: Quentin Glidic
> ---
>
> I do not kno
From: Quentin Glidic
Signed-off-by: Quentin Glidic
---
I do not know if this call is wrong of this the test just reveals a bug but
without this, the wl_resource_post_event_array is called with random values
tests/resources-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Hi,
I wrote a few tests which test client-display protocol.
These tests create it's own display so they are independent on weston.
WIll somebody be so kind and look at the code? :) I'd like to get some
feedback.
The code is here: https://github.com/mchalupa/wayland/tree/wits
All comments are wel
> -Original Message-
> From: Sam Spilsbury [mailto:smspil...@gmail.com]
>>
>>
>>
> Ah interesting. I guess the point of the tests is to verify the
> backends themselves as opposed to testing the core compositor (well,
> it tests that as an incident, but I guess its not the point?). Does it
On Mon, Apr 22, 2013 at 11:02 PM, Eoff, Ullysses A
wrote:
>> -Original Message-
>> From: Sam Spilsbury [mailto:smspil...@gmail.com]
>>>
>>>
>>>
>
> Yes, it would be trivial to enable the input-based tests to run on the
> headless backend... however, it's unclear to me whether the headl
iginal Message-
>>> > From: wayland-devel-
>>> bounces+ullysses.a.eoff=intel@lists.freedesktop.org
>>> > [mailto:wayland-devel-
>>> > bounces+ullysses.a.eoff=intel@lists.freedesktop.org] On Behalf Of Sam
>>> > Spilsbury
>>> &
f,
>> Ullysses A
>> Sent: Monday, April 22, 2013 1:24 PM
>> To: Sam Spilsbury; wayland
>> Subject: RE: [RFC] [tests] Running the wayland tests against
>> compositor-headless
>>
>> Changing the tests to run headless is probably not necessary...
>>
>
>
am Spilsbury; wayland
> Subject: RE: [RFC] [tests] Running the wayland tests against
> compositor-headless
>
> Changing the tests to run headless is probably not necessary...
>
To clarify... I only meant this in the context of the weston-tests-env script ,
i.e.
it does not need to be
uous integration server.
U. Artie Eoff
> -Original Message-
> From: wayland-devel-bounces+ullysses.a.eoff=intel@lists.freedesktop.org
> [mailto:wayland-devel-
> bounces+ullysses.a.eoff=intel@lists.freedesktop.org] On Behalf Of Sam
> Spilsbury
> Sent: Monday, April 22
Hi,
I'm not sure if this is a work-item that's already in-progress by
somebody. I noticed that weston has a "headless" compositor backend
and a "no-op" renderer, which effectively do not depend on having
OpenGL or *a* windowing system available at the time that weston is
run.
It would be really g
On Mon, Dec 03, 2012 at 04:58:25PM +0200, Pekka Paalanen wrote:
> This is libwayland, not weston, so call the temporary files
> wayland-tests-*, not weston-tests-*.
>
> This is a candidate for the stable branch.
Yeah, thanks, would've made it easier to track this leak down.
K
This is libwayland, not weston, so call the temporary files
wayland-tests-*, not weston-tests-*.
This is a candidate for the stable branch.
Signed-off-by: Pekka Paalanen
---
tests/connection-test.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/connection
On Tue, May 15, 2012 at 10:29:12AM +0300, Pekka Paalanen wrote:
> I was just curious of how much the looping takes time without
> conversion, so I added this.
>
> My results on Intel(R) Core(TM) i5-2410M CPU @ 2.30GHz:
>
> benchmarked noop: 1.876349827s
> benchmarked magic:2.245844470s
>
I was just curious of how much the looping takes time without
conversion, so I added this.
My results on Intel(R) Core(TM) i5-2410M CPU @ 2.30GHz:
benchmarked noop: 1.876349827s
benchmarked magic: 2.245844470s
benchmarked div:12.709085309s
benchmarked mul:7.504838141s
79 matches
Mail list logo
