Re: frame callbacks and sub_surfaces

2022-11-08 Thread Pekka Paalanen
On Mon, 7 Nov 2022 15:49:16 -0800 Joel Winarske wrote: > @pq > I think this approach might better suit our use cases (CI health gate / > client regression testing): > https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/24 > > I would be happy to push this forward, seeing it hasn't mov

Re: frame callbacks and sub_surfaces

2022-11-07 Thread Joel Winarske
> There's https://gitlab.freedesktop.org/wayland/wayland/-/issues/266 about this. Thanks, yes I have that book marked. @pq I think this approach might better suit our use cases (CI health gate / client regression testing): https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/24 I would

Re: frame callbacks and sub_surfaces

2022-11-07 Thread Michel Dänzer
On 2022-11-07 10:27, Pekka Paalanen wrote: > On Sat, 5 Nov 2022 16:14:44 -0700 > Joel Winarske wrote: > >> Does the base surface ever get occluded? > > Anything could be occluded or off-screen at any time. > > However, if parent surface is completely occluded/off-screen, then that > should not

Re: frame callbacks and sub_surfaces

2022-11-07 Thread Pekka Paalanen
On Sat, 5 Nov 2022 16:14:44 -0700 Joel Winarske wrote: > Okay thanks for the input. I sorted it out, and it's working great. > > My learning - Simply implement a frame callback for each sub surface and > base surface, empty or otherwise. No need for any other commit calls. > > What is the rec

Re: frame callbacks and sub_surfaces

2022-11-05 Thread Joel Winarske
Okay thanks for the input. I sorted it out, and it's working great. My learning - Simply implement a frame callback for each sub surface and base surface, empty or otherwise. No need for any other commit calls. What is the recommended solution for counting frame rate with sub surfaces? Does th

Re: frame callbacks and sub_surfaces

2022-11-04 Thread Pekka Paalanen
On Thu, 3 Nov 2022 15:14:00 -0700 Joel Winarske wrote: > Hi pq, > > I was thinking of a more full-featured example using sub surfaces with > runtime positioning and z-order control. > > That aside I am having an interesting problem. In case of multiple > surfaces, I only see the frame event fo

Re: frame callbacks and sub_surfaces

2022-11-03 Thread Joel Winarske
Hi pq, I was thinking of a more full-featured example using sub surfaces with runtime positioning and z-order control. That aside I am having an interesting problem. In case of multiple surfaces, I only see the frame event for the last added surface. Surface A is behind B and C (tiled), none oc

Re: frame callbacks and sub_surfaces

2022-11-02 Thread Pekka Paalanen
On Tue, 1 Nov 2022 20:08:10 -0700 Joel Winarske wrote: > Thanks for the clarification. Much appreciated. > > I'm interested in implementing a sub-surface example. Is a MR/PR of > interest? To which repository, and what do you want to demonstrate with it? E.g. https://gitlab.freedesktop.org/w

Re: frame callbacks and sub_surfaces

2022-11-01 Thread Joel Winarske
Thanks for the clarification. Much appreciated. I'm interested in implementing a sub-surface example. Is a MR/PR of interest? Thanks, Joel On Tue, Nov 1, 2022 at 1:53 AM Pekka Paalanen wrote: > On Mon, 31 Oct 2022 10:14:42 -0700 > Joel Winarske wrote: > > > Thank you for the enlightenment!

Re: frame callbacks and sub_surfaces

2022-11-01 Thread Pekka Paalanen
On Mon, 31 Oct 2022 10:14:42 -0700 Joel Winarske wrote: > Thank you for the enlightenment! > > Adding the ordered commit calls was the missing link. > > Do the commit calls need to happen based on the active Z-order, or based on > the order of surface creation? They need to be ordered by sub-s

Re: frame callbacks and sub_surfaces

2022-10-31 Thread Joel Winarske
Thank you for the enlightenment! Adding the ordered commit calls was the missing link. Do the commit calls need to happen based on the active Z-order, or based on the order of surface creation? Thanks again, Joel

Re: frame callbacks and sub_surfaces

2022-10-28 Thread Pekka Paalanen
On Wed, 26 Oct 2022 20:56:14 -0700 Joel Winarske wrote: > When using sub_surfaces what is the expected behavior for frame callbacks > on a given surface? Hi, frame callbacks will trigger at the compositor's discretion after the wl_surface update with that frame callback request is applied, and