Re: Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

2015-11-30 Thread Bill Spitzak
On Mon, Nov 23, 2015 at 7:54 PM, 이상진 wrote: > >> Also (on the patch) it looks like if there is an error it destroys the > >> wl_socket object, could this do the wrong thing if the fd was supplied > from > >> outside? > > > So like if the socket object couldn't be initted or added to the display >

Re: Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

2015-11-23 Thread 이상진
Title: Samsung Enterprise Portal mySingle >> Also (on the patch) it looks like if there is an error it destroys the>> wl_socket object, could this do the wrong thing if the fd was supplied from>> outside?> So like if the socket object couldn't be initted or added to the display> for some reason

Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

2015-11-23 Thread Bryce Harrington
On Thu, Nov 19, 2015 at 11:21:04AM -0800, Bill Spitzak wrote: > Also (on the patch) it looks like if there is an error it destroys the > wl_socket object, could this do the wrong thing if the fd was supplied from > outside? So like if the socket object couldn't be initted or added to the display f

Re: Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

2015-11-21 Thread 이상진
Title: Samsung Enterprise Portal mySingle I don't see any reason for the  wl_display_add_socket_fd_auto and wl_display_add_socket_auto functions, as they are the same as passing NULL for the name to wl_display_add_socket_fd, right?==> No, The wl_display_add_socket_fd_auto is different action to

Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

2015-11-19 Thread Bill Spitzak
I don't see any reason for the wl_display_add_socket_fd_auto and wl_display_add_socket_auto functions, as they are the same as passing NULL for the name to wl_display_add_socket_fd, right? Also (on the patch) it looks like if there is an error it destroys the wl_socket object, could this do the w