Re: Proposed rearrangement of wl_event_loop_dispatch

2012-07-09 Thread Bill Spitzak
David Herrmann wrote: Hi Bill On Mon, Jul 9, 2012 at 8:06 PM, Bill Spitzak wrote: Any comments on this? It is much easier to comment on and follow patches if you include them inline. Also, where is the git headline? I recommend using git-format-patch and optionally git-send-email (even fo

Re: Proposed rearrangement of wl_event_loop_dispatch

2012-07-09 Thread David Herrmann
Hi Bill On Mon, Jul 9, 2012 at 8:06 PM, Bill Spitzak wrote: > Any comments on this? > It is much easier to comment on and follow patches if you include them inline. Also, where is the git headline? I recommend using git-format-patch and optionally git-send-email (even for RFC patches). Regardin

Re: Proposed rearrangement of wl_event_loop_dispatch

2012-07-09 Thread Bill Spitzak
Any comments on this? On 06/27/2012 09:47 PM, Bill Spitzak wrote: If dispatch_idle_sources() has a side effect of reading from one of the epoll fd's it can cause the fd to become un-ready yet there are still events in the internal queue. This patch moves the (possibly mis-named) post_dispatch_c

Proposed rearrangement of wl_event_loop_dispatch

2012-06-27 Thread Bill Spitzak
If dispatch_idle_sources() has a side effect of reading from one of the epoll fd's it can cause the fd to become un-ready yet there are still events in the internal queue. This patch moves the (possibly mis-named) post_dispatch_check functions so that they are run after the dispatch_idle_sourc