Re: Interfaces to objects

2014-08-12 Thread Bill Spitzak
On 08/11/2014 11:34 PM, Pekka Paalanen wrote: void do_cool_thing_with_surface (???) { wl_surface_foo(???, args); wl_shell_surface_bar(???, args); } That is simply a broken design of that helper function. It likely also is an API layering violation. We need a real use case as an example

Re: Interfaces to objects

2014-08-11 Thread Pekka Paalanen
On Mon, 11 Aug 2014 16:50:10 -0700 Bill Spitzak wrote: > On 08/11/2014 04:19 PM, Jasper St. Pierre wrote: > > > What exactly happens if you call wl_shell::get_shell_surface with > > one of these? It does not do a round trip so it cannot fail. > > > > wl_display has an 'error' event which

Re: Interfaces to objects

2014-08-11 Thread Bill Spitzak
On 08/11/2014 04:19 PM, Jasper St. Pierre wrote: What exactly happens if you call wl_shell::get_shell_surface with one of these? It does not do a round trip so it cannot fail. wl_display has an 'error' event which is required to be a fatal error to the client. For subsurfaces, it will s

Re: Interfaces to objects

2014-08-11 Thread Jasper St. Pierre
On Mon, Aug 11, 2014 at 7:10 PM, Bill Spitzak wrote: > On 08/11/2014 03:03 PM, Jasper St. Pierre wrote: > > wl_shell does exist. It's a global object that is bound by the client, >> using wl_registry.bind. It's as real as any other object. >> > > What I meant was that the wl_registry::global eve

Re: Interfaces to objects

2014-08-11 Thread Bill Spitzak
On 08/11/2014 03:03 PM, Jasper St. Pierre wrote: wl_shell does exist. It's a global object that is bound by the client, using wl_registry.bind. It's as real as any other object. What I meant was that the wl_registry::global event with the wl_shell api was not sent if the compositor does not i

Re: Interfaces to objects

2014-08-11 Thread Jasper St. Pierre
On Mon, Aug 11, 2014 at 5:05 PM, Bill Spitzak wrote: > On 08/09/2014 02:21 AM, Pekka Paalanen wrote: > > You may be confusing wl_shell with wl_shell_surface. >> > > Indeed I am. Sorry about that. > > > And in Weston's case, if a client does not create a >> wl_shell_surface, the shell specific d

Re: Interfaces to objects

2014-08-11 Thread Bill Spitzak
On 08/09/2014 02:21 AM, Pekka Paalanen wrote: You may be confusing wl_shell with wl_shell_surface. Indeed I am. Sorry about that. And in Weston's case, if a client does not create a wl_shell_surface, the shell specific data for the wl_surface really does not exist inside Weston, literally.

Re: Interfaces to objects

2014-08-09 Thread Pekka Paalanen
On Fri, 08 Aug 2014 16:06:04 -0700 Bill Spitzak wrote: > This is my understanding. And this is one of the big confusing points > when trying to figure out the Wayland api, but I think there are good > reasons for it. The only real problem is that the auto-generated > documentation is not handl

Re: Interfaces to objects

2014-08-08 Thread Bill Spitzak
This is my understanding. And this is one of the big confusing points when trying to figure out the Wayland api, but I think there are good reasons for it. The only real problem is that the auto-generated documentation is not handling this nicely: A Wayland compositor has to support the functi

Re: Interfaces to objects

2014-08-08 Thread Jasper St. Pierre
On Tue, Jul 8, 2014 at 7:51 AM, Stephen Lee wrote: > Hey, I'm working on my own window manager and I'm having a hard time > tracking through the Weston code to see where a function is registered as > part of an interface. Right now I am looking at surfaces. I guess my > question is more related t

Interfaces to objects

2014-08-08 Thread Stephen Lee
Hey, I'm working on my own window manager and I'm having a hard time tracking through the Weston code to see where a function is registered as part of an interface. Right now I am looking at surfaces. I guess my question is more related to the relation of surface and shell surface. In the main comp