Re: Helping in reviewing

2013-03-27 Thread Thiago Macieira
On quarta-feira, 27 de março de 2013 14.15.14, Siddharth Heroor wrote: > > Recent circumstances have shown that patch reviewing in Wayland and Weston > > is becoming a bottleneck for development (at least, it is perceived to > > be). This email is intended to begin addressing that. > > Would settin

Re: Helping in reviewing

2013-03-27 Thread Siddharth Heroor
On Tue, Mar 26, 2013 at 11:22 PM, Thiago Macieira wrote: > Recent circumstances have shown that patch reviewing in Wayland and Weston is > becoming a bottleneck for development (at least, it is perceived to be). This > email is intended to begin addressing that. Would setting patchwork help in im

Re: Helping in reviewing

2013-03-27 Thread Gwenole Beauchesne
Hi, 2013/3/27 Pekka Paalanen : > On Tue, 26 Mar 2013 14:09:48 -0700 > Thiago Macieira wrote: > >> So whenever you see a change that you think you can provide input on, do so. >> If you don't feel like saying it's completely fine, say so too. The initial >> review you provide on simpler things (co

Re: Helping in reviewing

2013-03-27 Thread Pekka Paalanen
On Tue, 26 Mar 2013 14:09:48 -0700 Thiago Macieira wrote: > So whenever you see a change that you think you can provide input on, do so. > If you don't feel like saying it's completely fine, say so too. The initial > review you provide on simpler things (coding style, thread-safety, etc.) is >

Re: Helping in reviewing

2013-03-26 Thread Thiago Macieira
On terça-feira, 26 de março de 2013 12.50.46, Nick Kisialiou wrote: > I'm not a Wayland developer but I suspect it wouldn't be wise to lump > Wayland (protocol) and Weston (compositor) together on this issue. > > Wayland: > I'm not sure why it is a problem that Wayland patches take time to be > mer

Re: Helping in reviewing

2013-03-26 Thread Thiago Macieira
On terça-feira, 26 de março de 2013 19.32.54, Bernhard Friedreich wrote: > What I've been wondering lately (and also in the light of recent events) is > if there is a specific reason why there's no CI (Jenkins?) and/or > reviewboard system (Gerrit?). Is it because reviewing patches on the > maillin

Re: Helping in reviewing

2013-03-26 Thread Nick Kisialiou
I'm not a Wayland developer but I suspect it wouldn't be wise to lump Wayland (protocol) and Weston (compositor) together on this issue. Wayland: I'm not sure why it is a problem that Wayland patches take time to be merged. Isn't it the whole point of any protocol to be as stable as possible? If t

Re: Helping in reviewing

2013-03-26 Thread Bernhard Friedreich
Hi! I've been reading this list since the start of wayland/weston (on google groups) and would like to thank you all for your ongoing effort :) What I've been wondering lately (and also in the light of recent events) is if there is a specific reason why there's no CI (Jenkins?) and/or reviewboard

Helping in reviewing

2013-03-26 Thread Thiago Macieira
Recent circumstances have shown that patch reviewing in Wayland and Weston is becoming a bottleneck for development (at least, it is perceived to be). This email is intended to begin addressing that. TL;DR: if you want to help, the best thing you can do right now is review other people's contri