Re: Clang format config for Weston

2019-03-14 Thread Harish Krupo
Hi, I dumped the llvm configuration from clang-format, edited it and pruned all the unneeded configs (like configs for other langauges). I have to agree with Simon. It is indeed impossible to be able to get the requirements exactly right with clang. I managed to get almost all the configs right bu

Re: Clang format config for Weston

2019-03-14 Thread Harish Krupo
Hi Simon, Simon Ser writes: > On Thursday, March 14, 2019 12:20 PM, Harish Krupo > wrote: > >> Hi Pekka, >> >> Pekka Paalanen ppaala...@gmail.com writes: >> >> > On Thu, 14 Mar 2019 16:01:08 +0530 >> > Harish Krupo harish.krupo@intel.com wrote: >> > >> > > Hi, >> > > I have written a clang

Re: Clang format config for Weston

2019-03-14 Thread Harish Krupo
Pekka Paalanen writes: > On Thu, 14 Mar 2019 18:11:47 +0530 > Harish Krupo wrote: > >> Pekka Paalanen writes: > >> > FYI, one thing I would never want to see in a patch is adding >> > '/* clang-format off */' kind of directives into code. >> > >> >> /* clang-format off */ directive is suppo

Re: Clang format config for Weston

2019-03-14 Thread Pekka Paalanen
On Thu, 14 Mar 2019 18:11:47 +0530 Harish Krupo wrote: > Pekka Paalanen writes: > > FYI, one thing I would never want to see in a patch is adding > > '/* clang-format off */' kind of directives into code. > > > > /* clang-format off */ directive is supposed to be used sparingly. If > the who

Re: Clang format config for Weston

2019-03-14 Thread Harish Krupo
Pekka Paalanen writes: > On Thu, 14 Mar 2019 16:57:08 +0530 > Harish Krupo wrote: > >> Harish Krupo writes: >> >> > Hi Pekka, >> > >> > Pekka Paalanen writes: >> > >> >> On Thu, 14 Mar 2019 16:01:08 +0530 >> >> Harish Krupo wrote: >> >> >> >>> Hi, >> >>> >> >>> I have written a clang f

Re: Clang format config for Weston

2019-03-14 Thread Pekka Paalanen
On Thu, 14 Mar 2019 16:57:08 +0530 Harish Krupo wrote: > Harish Krupo writes: > > > Hi Pekka, > > > > Pekka Paalanen writes: > > > >> On Thu, 14 Mar 2019 16:01:08 +0530 > >> Harish Krupo wrote: > >> > >>> Hi, > >>> > >>> I have written a clang format file based on this example [1], to >

Re: Clang format config for Weston

2019-03-14 Thread Simon Ser
On Thursday, March 14, 2019 12:20 PM, Harish Krupo wrote: > Hi Pekka, > > Pekka Paalanen ppaala...@gmail.com writes: > > > On Thu, 14 Mar 2019 16:01:08 +0530 > > Harish Krupo harish.krupo@intel.com wrote: > > > > > Hi, > > > I have written a clang format file based on this example [1], to >

Re: Clang format config for Weston

2019-03-14 Thread Harish Krupo
Harish Krupo writes: > Hi Pekka, > > Pekka Paalanen writes: > >> On Thu, 14 Mar 2019 16:01:08 +0530 >> Harish Krupo wrote: >> >>> Hi, >>> >>> I have written a clang format file based on this example [1], to >>> match the coding style here [2]. Does the below config look okay or >>> should som

Re: Clang format config for Weston

2019-03-14 Thread Harish Krupo
Hi Pekka, Pekka Paalanen writes: > On Thu, 14 Mar 2019 16:01:08 +0530 > Harish Krupo wrote: > >> Hi, >> >> I have written a clang format file based on this example [1], to >> match the coding style here [2]. Does the below config look okay or >> should something be changed? >> If people are in

Re: Clang format config for Weston

2019-03-14 Thread Pekka Paalanen
On Thu, 14 Mar 2019 16:01:08 +0530 Harish Krupo wrote: > Hi, > > I have written a clang format file based on this example [1], to > match the coding style here [2]. Does the below config look okay or > should something be changed? > If people are interested, I can open a MR for this. This could

Clang format config for Weston

2019-03-14 Thread Harish Krupo
Hi, I have written a clang format file based on this example [1], to match the coding style here [2]. Does the below config look okay or should something be changed? If people are interested, I can open a MR for this. This could also be used in the CI to warn/abort if a patch isn't according to th