Re:[weston] weston-terminal: Add a few nice features

2015-09-23 Thread ahmet acar
>I'm going to apologize upfront, since what lies below is a pretty >intense review First; thank you for your intense review.i am happy with it. > I hope you'll fix up your patch and resubmit Sure. >Sounds useful! I would suggestion though to make your commit >message more >descriptive oriented

Re: [weston] weston-terminal: Add a few nice features

2015-09-22 Thread Bryce Harrington
On Mon, Sep 21, 2015 at 03:24:49PM +0300, ahmet acar wrote: > Hi.This trivial patch adds 'cwd' (current working directory) > and 'command' (run specified command immediatelly after open) > features to weston-terminal.So this adds more use cases > and flexibility to our terminal. Sounds useful! I

[weston] weston-terminal: Add a few nice features

2015-09-21 Thread ahmet acar
Hi.This trivial patch adds 'cwd' (current working directory) and 'command' (run specified command immediatelly after open) features to weston-terminal.So this adds more use cases and flexibility to our terminal. Changes from: commit 90e2d07ec1e6e46136e7b43f427a838f3e5b01ed Author: Bryce Harrington