Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 01:29:04PM +0200, Dorota Czaplejewicz wrote: > On Mon, 30 Jul 2018 13:09:06 +0200 > Jonas Ådahl wrote: > > > On Mon, Jul 30, 2018 at 12:57:52PM +0200, Dorota Czaplejewicz wrote: > > > On Mon, 30 Jul 2018 12:36:45 +0200 > > > Jonas Ådahl wrote: > > > > > > > On Sat, Jul

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
On Mon, 30 Jul 2018 13:09:06 +0200 Jonas Ådahl wrote: > On Mon, Jul 30, 2018 at 12:57:52PM +0200, Dorota Czaplejewicz wrote: > > On Mon, 30 Jul 2018 12:36:45 +0200 > > Jonas Ådahl wrote: > > > > > On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > > > > From: Carlos Garn

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 12:57:52PM +0200, Dorota Czaplejewicz wrote: > On Mon, 30 Jul 2018 12:36:45 +0200 > Jonas Ådahl wrote: > > > On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > > > From: Carlos Garnacho > > > > > > This new protocol description is an evolution of v2.

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
On Mon, 30 Jul 2018 12:36:45 +0200 Jonas Ådahl wrote: > On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > > From: Carlos Garnacho > > > > This new protocol description is an evolution of v2. > > > > - All pre-edit text styling is gone. > > - Pre-edit cursor can span charac

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered rect

[PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-28 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is an evolution of v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard focus

[PATCH v7 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-24 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is a simplification over v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

[PATCH v6 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-23 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is a simplification over v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

[PATCH v5 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-23 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is a simplification over v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-23 Thread Dorota Czaplejewicz
Hi Carlos, thanks for reviewing! On Tue, 17 Jul 2018 19:18:36 +0200 Carlos Garnacho wrote: > Hi!, > > (Way way late, trying to revive the conversation...) > > On Thu, May 3, 2018 at 9:22 PM, Dorota Czaplejewicz > wrote: > > On Thu, 3 May 2018 20:47:27 +0200 > > Silvan Jegen wrote: > > > >

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-17 Thread Carlos Garnacho
Hi!, (Way way late, trying to revive the conversation...) On Thu, May 3, 2018 at 9:22 PM, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 20:47:27 +0200 > Silvan Jegen wrote: > >> Hi Dorota >> >> Some comments and typo fixes below. >> >> On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czapleje

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-17 Thread Dorota Czaplejewicz
On Thu, 17 May 2018 18:05:34 +0100 Daniel Stone wrote: > Hi Dorota, > > On 3 May 2018 at 16:41, Dorota Czaplejewicz > wrote: > > - There is no event to send keysyms. Compositors can use wl_keyboard > > interface instead. > > The reason we explicitly chose to have a keysym (really, 'Unicod

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-17 Thread Daniel Stone
Hi Dorota, On 3 May 2018 at 16:41, Dorota Czaplejewicz wrote: > - There is no event to send keysyms. Compositors can use wl_keyboard > interface instead. The reason we explicitly chose to have a keysym (really, 'Unicode codepoint') event, is to support characters which don't appear in any keym

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-10 Thread Silvan Jegen
On Thu, May 10, 2018 at 11:46:32AM +0200, Dorota Czaplejewicz wrote: > On Thu, 10 May 2018 11:43:12 +0200 > Dorota Czaplejewicz wrote: > > > On Tue, 08 May 2018 07:07:24 + > > Silvan Jegen wrote: > > > > > On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > > > > IMHO, if you are doing U

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-10 Thread Dorota Czaplejewicz
On Thu, 10 May 2018 11:43:12 +0200 Dorota Czaplejewicz wrote: > On Tue, 08 May 2018 07:07:24 + > Silvan Jegen wrote: > > > On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > > > IMHO, if you are doing UTF-8 (which you should), you should *always* > > > specify any offset in the string a

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-10 Thread Dorota Czaplejewicz
On Tue, 08 May 2018 07:07:24 + Silvan Jegen wrote: > On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > > IMHO, if you are doing UTF-8 (which you should), you should *always* > > specify any offset in the string as a byte offset. I have a few > > reasons for this justification: > > I agr

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-08 Thread Silvan Jegen
On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > IMHO, if you are doing UTF-8 (which you should), you should *always* > specify any offset in the string as a byte offset. I have a few > reasons for this justification: I agree with this as well. I thought some more about how to spell out my gut

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-07 Thread Silvan Jegen
Hi Joshua On Sun, May 06, 2018 at 10:11:32PM -0500, Joshua Watt wrote: > On Sun, May 6, 2018 at 3:37 PM, Dorota Czaplejewicz > wrote: > > Unless someone chimes in with more arguments, I'm going to keep > > using code points in following revisions. > > I don't mean to do a drive by or bikeshed, I

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-07 Thread Silvan Jegen
On Sun, May 06, 2018 at 10:37:57PM +0200, Dorota Czaplejewicz wrote: > On Sat, 5 May 2018 13:37:44 +0200 > Silvan Jegen wrote: > > > On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > > > On Fri, 4 May 2018 22:32:15 +0200 > > > Silvan Jegen wrote: > > > > > > > On Thu, May

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-07 Thread Dorota Czaplejewicz
On Sun, 6 May 2018 22:11:32 -0500 Joshua Watt wrote: > On Sun, May 6, 2018 at 3:37 PM, Dorota Czaplejewicz > wrote: > > On Sat, 5 May 2018 13:37:44 +0200 > > Silvan Jegen wrote: > > > >> On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > >> > On Fri, 4 May 2018 22:32:15

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-06 Thread Joshua Watt
On Sun, May 6, 2018 at 3:37 PM, Dorota Czaplejewicz wrote: > On Sat, 5 May 2018 13:37:44 +0200 > Silvan Jegen wrote: > >> On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: >> > On Fri, 4 May 2018 22:32:15 +0200 >> > Silvan Jegen wrote: >> > >> > > On Thu, May 03, 2018 at 10:46

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-06 Thread Dorota Czaplejewicz
On Sat, 5 May 2018 13:37:44 +0200 Silvan Jegen wrote: > On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > > On Fri, 4 May 2018 22:32:15 +0200 > > Silvan Jegen wrote: > > > > > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > > > > On Thu, 3 May 201

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-05 Thread Silvan Jegen
On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > On Fri, 4 May 2018 22:32:15 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 21:55:40 +0200 > > > Silvan Jegen wrote: > > > > > > > On Thu, May

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-05 Thread Dorota Czaplejewicz
On Fri, 4 May 2018 22:32:15 +0200 Silvan Jegen wrote: > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > > On Thu, 3 May 2018 21:55:40 +0200 > > Silvan Jegen wrote: > > > > > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > > > On Thu, 3 May 201

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-04 Thread Silvan Jegen
On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 21:55:40 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 20:47:27 +0200 > > > Silvan Jegen wrote: > > > > > > > Hi Dorota >

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Dorota Czaplejewicz
On Thu, 3 May 2018 21:55:40 +0200 Silvan Jegen wrote: > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > On Thu, 3 May 2018 20:47:27 +0200 > > Silvan Jegen wrote: > > > > > Hi Dorota > > > > > > Some comments and typo fixes below. > > > > > > On Thu, May 03, 2018 at

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Silvan Jegen
On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 20:47:27 +0200 > Silvan Jegen wrote: > > > Hi Dorota > > > > Some comments and typo fixes below. > > > > On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > > > This new protocol descrip

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Dorota Czaplejewicz
On Thu, 3 May 2018 20:47:27 +0200 Silvan Jegen wrote: > Hi Dorota > > Some comments and typo fixes below. > > On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > > This new protocol description is a simplification over v2. > > > > - All pre-edit text styling is gone. > > - P

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Silvan Jegen
Hi Dorota Some comments and typo fixes below. On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > This new protocol description is a simplification over v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (O

[PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is a simplification over v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Dorota Czaplejewicz
On Thu, 12 Apr 2018 10:35:04 +0200 Jonas Ådahl wrote: > On Thu, Apr 12, 2018 at 12:13:49AM +0200, Carlos Garnacho wrote: > > Hi!, > > > > On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > > > (forgot to reply to the list) > > > > > > On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaple

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Jonas Ådahl
On Thu, Apr 12, 2018 at 12:13:49AM +0200, Carlos Garnacho wrote: > Hi!, > > On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > > (forgot to reply to the list) > > > > On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaplejewicz wrote: > >> On Wed, 11 Apr 2018 11:26:22 -0700 > >> > >> Weng Xue

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-11 Thread Carlos Garnacho
Hi!, On Wed, Apr 11, 2018 at 8:52 PM, Weng Xuetian wrote: > (forgot to reply to the list) > > On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaplejewicz wrote: >> On Wed, 11 Apr 2018 11:26:22 -0700 >> >> Weng Xuetian wrote: >> > On Monday, 9 April 2018 07:20:53 PDT Dorota Czaplejewicz wrote: >

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-11 Thread Weng Xuetian
(forgot to reply to the list) On Wednesday, 11 April 2018 11:35:58 PDT Dorota Czaplejewicz wrote: > On Wed, 11 Apr 2018 11:26:22 -0700 > > Weng Xuetian wrote: > > On Monday, 9 April 2018 07:20:53 PDT Dorota Czaplejewicz wrote: > > > On Sun, 11 Mar 2018 20:30:14 +0100 > > > > > > Carlos Garnacho

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-11 Thread Dorota Czaplejewicz
On Wed, 11 Apr 2018 11:26:22 -0700 Weng Xuetian wrote: > On Monday, 9 April 2018 07:20:53 PDT Dorota Czaplejewicz wrote: > > On Sun, 11 Mar 2018 20:30:14 +0100 > > > > Carlos Garnacho wrote: > > > This new protocol description is a vast simplification over v2, highlights > > > are: > > > - Al

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-11 Thread Weng Xuetian
On Monday, 9 April 2018 07:20:53 PDT Dorota Czaplejewicz wrote: > On Sun, 11 Mar 2018 20:30:14 +0100 > > Carlos Garnacho wrote: > > This new protocol description is a vast simplification over v2, highlights > > are: > > - All pre-edit text styling is gone, the protocol doesn't seem the place > >

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-09 Thread Dorota Czaplejewicz
On Sun, 11 Mar 2018 20:30:14 +0100 Carlos Garnacho wrote: > This new protocol description is a vast simplification over v2, highlights > are: > - All pre-edit text styling is gone, the protocol doesn't seem the place > to convey UI state. Clients are in better knowledge of how to make the > p

Re: [wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-02 Thread Dorota Czaplejewicz
On Sun, 11 Mar 2018 20:30:14 +0100 Carlos Garnacho wrote: > This new protocol description is a vast simplification over v2, highlights > are: > - All pre-edit text styling is gone, the protocol doesn't seem the place > to convey UI state. Clients are in better knowledge of how to make the > p

Re: [PATCH wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-01 Thread Silvan Jegen
Hi Please find some comments and questions below. On Sun, Mar 11, 2018 at 08:30:14PM +0100, Carlos Garnacho wrote: > This new protocol description is a vast simplification over v2, highlights > are: > - All pre-edit text styling is gone, the protocol doesn't seem the place > to convey UI state.

[PATCH wayland-protocols] text-input: Add v3 of the text-input protocol

2018-03-11 Thread Carlos Garnacho
This new protocol description is a vast simplification over v2, highlights are: - All pre-edit text styling is gone, the protocol doesn't seem the place to convey UI state. Clients are in better knowledge of how to make the pre-edit string distinguishable from regular text. - No input panel (OS