Re: [RFC wayland] tests: Test wl_message_count_arrays

2016-11-01 Thread Giulio Camuffo
2016-11-01 18:49 GMT+01:00 Yong Bakos : > On Nov 1, 2016, at 10:35 AM, Giulio Camuffo wrote: >> >> Hi, >> >> I think i would put more messages in the array, just two seems like >> it's not really testing much. Besides that it looks good. >> >> >> Cheers, >> Giulio > > Thanks Giulio, I'll add some

Re: [RFC wayland] tests: Test wl_message_count_arrays

2016-11-01 Thread Yong Bakos
On Nov 1, 2016, at 10:35 AM, Giulio Camuffo wrote: > > Hi, > > I think i would put more messages in the array, just two seems like > it's not really testing much. Besides that it looks good. > > > Cheers, > Giulio Thanks Giulio, I'll add some more. My main concern (hence the RFC) is about ABI

Re: [RFC wayland] tests: Test wl_message_count_arrays

2016-11-01 Thread Giulio Camuffo
Hi, I think i would put more messages in the array, just two seems like it's not really testing much. Besides that it looks good. Cheers, Giulio 2016-10-27 17:58 GMT+02:00 Yong Bakos : > From: Yong Bakos > > message-test.c did not cover wl_message_count_arrays, so add one test that > specifica

[RFC wayland] tests: Test wl_message_count_arrays

2016-10-27 Thread Yong Bakos
From: Yong Bakos message-test.c did not cover wl_message_count_arrays, so add one test that specifically tests this method. Note that this exposes wl_message_count_arrays in a private header (wayland-private.h), and removes the `static` modifier of the implementation. Signed-off-by: Yong Bakos