Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Ping Cheng
On Tuesday, November 22, 2016, Peter Hutterer wrote: > On Tue, Nov 22, 2016 at 09:03:52AM -0800, Ping Cheng wrote: > > On Tuesday, November 22, 2016, Daniel Stone > wrote: > > > > > Hey, > > > > > > On 21 November 2016 at 23:13, Peter Hutterer > > > > wrote: > > > > On Mon, Nov 21, 2016 at 12:

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Peter Hutterer
On Tue, Nov 22, 2016 at 09:03:52AM -0800, Ping Cheng wrote: > On Tuesday, November 22, 2016, Daniel Stone wrote: > > > Hey, > > > > On 21 November 2016 at 23:13, Peter Hutterer > > wrote: > > > On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > > >> Concretely though, reusing BTN_*

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Ping Cheng
On Tuesday, November 22, 2016, Daniel Stone wrote: > Hey, > > On 21 November 2016 at 23:13, Peter Hutterer > wrote: > > On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > >> Concretely though, reusing BTN_* codes where possible would make it > >> easier for clients to transition bet

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Daniel Stone
Hey, On 21 November 2016 at 23:13, Peter Hutterer wrote: > On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: >> Concretely though, reusing BTN_* codes where possible would make it >> easier for clients to transition between the two. > > I disagree here. The kernel only has BTN_STYLUS

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-21 Thread Peter Hutterer
On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > Hi, > > On 20 November 2016 at 05:14, Peter Hutterer wrote: > > Rather than relying on input-event-codes, define our own enum that is > > tailored > > towards the tablet interface. > > > > Signed-off-by: Peter Hutterer > > --- > >

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-21 Thread Daniel Stone
Hi, On 20 November 2016 at 05:14, Peter Hutterer wrote: > Rather than relying on input-event-codes, define our own enum that is tailored > towards the tablet interface. > > Signed-off-by: Peter Hutterer > --- > Because it's usually easier to pick holes into a patch proposal than come up > with i

[RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-19 Thread Peter Hutterer
Rather than relying on input-event-codes, define our own enum that is tailored towards the tablet interface. Signed-off-by: Peter Hutterer --- Because it's usually easier to pick holes into a patch proposal than come up with ideas elsewhere, here's a quick-and-dirty patch. Advantage: we control