Re: [RFC libinput] Import buttonset interface

2016-05-03 Thread PrasannaKumar Muralidharan
> simply said, I don't know. It's one of the things where we have to write > most of the interface, see if it makes sense and then remove the bits that > we don't actually need. your main target right now is a rotary encoder > but I do encourage you to think of how to deal with other devices that a

Re: [RFC libinput] Import buttonset interface

2016-04-25 Thread Peter Hutterer
On Fri, Apr 22, 2016 at 10:51:40PM +0530, PrasannaKumar Muralidharan wrote: > > fwiw, it's very frowned upon to take someone else's patch, rebase it and > > then send it on as your own when it has very little changes. Please keep > > original authorship while it makes sense and add the author as co

Re: [RFC libinput] Import buttonset interface

2016-04-22 Thread PrasannaKumar Muralidharan
> fwiw, it's very frowned upon to take someone else's patch, rebase it and > then send it on as your own when it has very little changes. Please keep > original authorship while it makes sense and add the author as co-author > where substantial changes have been made. I definitely did not intend t

Re: [RFC libinput] Import buttonset interface

2016-04-21 Thread Peter Hutterer
On Fri, Apr 22, 2016 at 12:00:43AM +0530, PrasannaKumar Muralidharan wrote: > From: PrasannaKumar Muralidharan fwiw, it's very frowned upon to take someone else's patch, rebase it and then send it on as your own when it has very little changes. Please keep original authorship while it makes sense

[RFC libinput] Import buttonset interface

2016-04-21 Thread PrasannaKumar Muralidharan
From: PrasannaKumar Muralidharan Import buttonset interface code from https://github.com/whot/libinput/tree/wip/buttonbox-interface. There is no user for buttonset interface as of now. I have taken the buttonset interface code and removed code related to wacom tablet. Please review the changes.