Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Peter Hutterer
On Thu, Jan 29, 2015 at 06:42:54PM +0100, Hans de Goede wrote: > Hi, > > On 29-01-15 16:23, Carlos Garnacho wrote: > >Hey Peter, > > > >On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: > > > > >>Isn't this mostly a UI issue than the gesture itself? Most gestures you > >>"undo" by doing

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Hans de Goede
Hi, On 29-01-15 16:23, Carlos Garnacho wrote: Hey Peter, On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: Isn't this mostly a UI issue than the gesture itself? Most gestures you "undo" by doing the reverse. when you start pinching, expanding the fingers restores you back to the ori

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Carlos Garnacho
Hey Peter, On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: > On 29/01/2015 20:58 , Carlos Garnacho wrote: > > On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: > >> On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: > >>> Hey, > >>> > >>> On mié, 2015-01-28 at 15:51 +

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Peter Hutterer
On 29/01/2015 20:58 , Carlos Garnacho wrote: > On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: >> On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: >>> Hey, >>> >>> On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Carlos Garnacho
On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: > On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: > > Hey, > > > > On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 28-01-15 13:59, Carlos Garnacho wrote: > > > > Hey Hans!, > > > > > > > > (

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Hans de Goede
Hi, On 29-01-15 07:11, Peter Hutterer wrote: On Wed, Jan 28, 2015 at 04:02:20PM +0100, Hans de Goede wrote: Hi, On 28-01-15 14:02, Carlos Garnacho wrote: Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: Ok, I'll change this to mm for v3 then (just send v2 addressing the

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Hans de Goede
Hi, On 28-01-15 19:18, Carlos Garnacho wrote: Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: +

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Peter Hutterer
On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: > Hey, > > On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: > > Hi, > > > > On 28-01-15 13:59, Carlos Garnacho wrote: > > > Hey Hans!, > > > > > > (sorry for chiming in late, things got busy around Fosdem...) > > > > > > On j

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Peter Hutterer
On Wed, Jan 28, 2015 at 04:02:20PM +0100, Hans de Goede wrote: > Hi, > > On 28-01-15 14:02, Carlos Garnacho wrote: > >Hey Hans, > > > >On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: > > > > >>>Ok, I'll change this to mm for v3 then (just send v2 addressing the other > >>>review comment

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: > Hi, > > On 28-01-15 13:59, Carlos Garnacho wrote: > > Hey Hans!, > > > > (sorry for chiming in late, things got busy around Fosdem...) > > > > On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: > >> + LIBINPUT_EVENT_GESTURE_SWIP

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Hans de Goede
Hi, On 28-01-15 14:02, Carlos Garnacho wrote: Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: Ok, I'll change this to mm for v3 then (just send v2 addressing the other review comments and adding a core implementation). So I've been thinking more about this and I'm still

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Hans de Goede
Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600, + LIBINPUT_EVENT_GESTURE_SWIPE, + LIBINPUT_EVENT_GESTURE

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 14:57, Hans de Goede wrote: > > Hi, > > > > On 23-01-15 14:53, Jonas Ådahl wrote: > >> On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 23-01-15 05:21, Peter Hutterer wro

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hi Jonas, On mar, 2015-01-27 at 15:17 +0800, Jonas Ådahl wrote: > > more the former than the latter. we don't really provide a way to associate > > the two event sequences with each other, so a caller would have to track > > whether we're currently scrolling or gesturing and discard the > > gestur

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Jonas, On mar, 2015-01-27 at 13:49 +0800, Jonas Ådahl wrote: > > > > anyway, the other escape hatch we have is: we don't _have_ to support all > > gestures. 2fg scrolling and swiping are incompatible, so short of changing > > all scrolling to swiping and letting the caller deal with the di

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: > + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600, > + LIBINPUT_EVENT_GESTURE_SWIPE, > + LIBINPUT_EVENT_GESTURE_SWIPE_END, > }; > One thing I'm unsure about

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Hans de Goede
Hi, On 23-01-15 14:57, Hans de Goede wrote: Hi, On 23-01-15 14:53, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: Hi, On 23-01-15 05:21, Peter Hutterer wrote: +double +libinput_event_gesture_get_absolute_x(struct libinput_event_gesture *event); this

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Bill Spitzak
On 01/26/2015 09:49 PM, Jonas Ådahl wrote: I'd say either this (2fg swipe doesn't exist), or generate both scroll events and 2fg swipe gesture events for 2fg swiping movements. Either the 2fg scroll feature "eats" its corresponding swipe gesture feaure and we ignore its existance, or we emit mul

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Jonas Ådahl
On Tue, Jan 27, 2015 at 10:12:20AM +0100, Hans de Goede wrote: > Hi, > > On 27-01-15 05:22, Peter Hutterer wrote: > > > > >or, even easier: 2fg swipe doesn't exist, use scrolling instead. > > Right, that is what I'm going for, big +1 AFAIK other OS don't > even have 2fg swipe, why would we in

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Hans de Goede
Hi, On 27-01-15 05:22, Peter Hutterer wrote: or, even easier: 2fg swipe doesn't exist, use scrolling instead. Right, that is what I'm going for, big +1 AFAIK other OS don't even have 2fg swipe, why would we invent something new here, and getting ourselves in a place of hurt while doing so.

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-26 Thread Jonas Ådahl
On Tue, Jan 27, 2015 at 04:55:44PM +1000, Peter Hutterer wrote: > On Tue, Jan 27, 2015 at 01:49:30PM +0800, Jonas Ådahl wrote: > > On Tue, Jan 27, 2015 at 02:22:02PM +1000, Peter Hutterer wrote: > > > On Tue, Jan 27, 2015 at 10:55:50AM +0800, Jonas Ådahl wrote: > > > > On Tue, Jan 27, 2015 at 12:15

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-26 Thread Peter Hutterer
On Tue, Jan 27, 2015 at 01:49:30PM +0800, Jonas Ådahl wrote: > On Tue, Jan 27, 2015 at 02:22:02PM +1000, Peter Hutterer wrote: > > On Tue, Jan 27, 2015 at 10:55:50AM +0800, Jonas Ådahl wrote: > > > On Tue, Jan 27, 2015 at 12:15:49PM +1000, Peter Hutterer wrote: > > > > On Fri, Jan 23, 2015 at 12:20

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-26 Thread Jonas Ådahl
On Tue, Jan 27, 2015 at 02:22:02PM +1000, Peter Hutterer wrote: > On Tue, Jan 27, 2015 at 10:55:50AM +0800, Jonas Ådahl wrote: > > On Tue, Jan 27, 2015 at 12:15:49PM +1000, Peter Hutterer wrote: > > > On Fri, Jan 23, 2015 at 12:20:55PM +0100, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 23-

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-26 Thread Peter Hutterer
On Tue, Jan 27, 2015 at 10:55:50AM +0800, Jonas Ådahl wrote: > On Tue, Jan 27, 2015 at 12:15:49PM +1000, Peter Hutterer wrote: > > On Fri, Jan 23, 2015 at 12:20:55PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 23-01-15 09:51, Jonas Ådahl wrote: > > > >On Fri, Jan 23, 2015 at 09:38:06AM +0

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-26 Thread Jonas Ådahl
On Tue, Jan 27, 2015 at 12:15:49PM +1000, Peter Hutterer wrote: > On Fri, Jan 23, 2015 at 12:20:55PM +0100, Hans de Goede wrote: > > Hi, > > > > On 23-01-15 09:51, Jonas Ådahl wrote: > > >On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: > > >>Hi, > > >> > > >>On 23-01-15 07:18, Jonas

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-26 Thread Peter Hutterer
On Fri, Jan 23, 2015 at 12:20:55PM +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 09:51, Jonas Ådahl wrote: > >On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: > >>Hi, > >> > >>On 23-01-15 07:18, Jonas Ådahl wrote: > > > > As for 2 finger swipe at least: isn't that covered

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 14:53, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: Hi, On 23-01-15 05:21, Peter Hutterer wrote: +double +libinput_event_gesture_get_absolute_x(struct libinput_event_gesture *event); this is a bit inconsistent with the other API where

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Jonas Ådahl
On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 05:21, Peter Hutterer wrote: > >CC-ing Carlos too, I'd like to get his input here. > > > >On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: > >>For touchscreens we always send raw touch events to the

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 09:51, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: Hi, On 23-01-15 07:18, Jonas Ådahl wrote: As for 2 finger swipe at least: isn't that covered by scrolling? with the caller deciding when a scroll event event is a swipe and when it is

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 05:21, Peter Hutterer wrote: CC-ing Carlos too, I'd like to get his input here. On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition.

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Jonas Ådahl
On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 07:18, Jonas Ådahl wrote: > >On Fri, Jan 23, 2015 at 03:11:31PM +1000, Peter Hutterer wrote: > >>On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: > >>>On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 07:18, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 03:11:31PM +1000, Peter Hutterer wrote: On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the composi

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-22 Thread Jonas Ådahl
On Fri, Jan 23, 2015 at 03:11:31PM +1000, Peter Hutterer wrote: > On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: > > On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: > > > For touchscreens we always send raw touch events to the compositor, and > > > the > > > compositor

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-22 Thread Peter Hutterer
On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: > On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: > > For touchscreens we always send raw touch events to the compositor, and the > > compositor or application toolkits do gesture recognition. This makes sense > > because o

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-22 Thread Peter Hutterer
CC-ing Carlos too, I'd like to get his input here. On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: > For touchscreens we always send raw touch events to the compositor, and the > compositor or application toolkits do gesture recognition. This makes sense > because on a touchscreen w

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-22 Thread Jonas Ådahl
On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: > For touchscreens we always send raw touch events to the compositor, and the > compositor or application toolkits do gesture recognition. This makes sense > because on a touchscreen which window / widget the touches are over is > impor

[RFC libinput] Add an API for touchpad gesture events

2015-01-22 Thread Hans de Goede
For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which window / widget the touches are over is important context to know to interpret gestures. On touchpads however we ne