Re: [RFC] compositor: Simple key repeat implementation.

2012-03-11 Thread Joakim Sindholt
On Fri, 2012-03-09 at 10:53 +, Daniel Stone wrote: > Hi, > > On 8 March 2012 18:20, Joakim Sindholt wrote: > > I think that wayland should be consistent across the board and act > > *only* as a display server and otherwise implement only the minimum set > > of features necessary for proper op

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-09 Thread Daniel Stone
Hi, On 8 March 2012 18:20, Joakim Sindholt wrote: > I think that wayland should be consistent across the board and act > *only* as a display server and otherwise implement only the minimum set > of features necessary for proper operation. That entails (what I think > was the original intent) only

Re: [RFC] compositor: Simple key repeat implementation

2012-03-08 Thread Bill Spitzak
Joakim Sindholt wrote: Any particular reason that this is in the server and not the toolkits? I'm of the persuasion that wayland should just function as a relay here. I think this is acceptable in the server. It is very important however that clients can always recover the "real" events, so i

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Joakim Sindholt
On Thu, 2012-03-08 at 16:10 +0100, Michael Hasselmann wrote: > On Thu, 2012-03-08 at 14:52 +0100, Joakim Sindholt wrote: > > On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > > > There's nothing fancy about this, we just set a timer and simulate > > > events using states 2 and 3 for repeat-u

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Scott Moreau
On Thu, Mar 8, 2012 at 6:52 AM, Joakim Sindholt wrote: > On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and simulate > > events using states 2 and 3 for repeat-up and repeat-down events. > > Any particular reason that this is in the

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Michael Hasselmann
On Thu, 2012-03-08 at 14:52 +0100, Joakim Sindholt wrote: > On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and simulate > > events using states 2 and 3 for repeat-up and repeat-down events. > > Any particular reason that this is in

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Joakim Sindholt
On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > There's nothing fancy about this, we just set a timer and simulate > events using states 2 and 3 for repeat-up and repeat-down events. Any particular reason that this is in the server and not the toolkits? I'm of the persuasion that wayland

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Michael Hasselmann
On Wed, 2012-03-07 at 15:35 -0700, Scott Moreau wrote: > > > On Wed, Mar 7, 2012 at 3:27 PM, Daniel Stone > wrote: > Hi, > > On 7 March 2012 22:21, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and > simulate > > e

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-07 Thread Scott Moreau
On Wed, Mar 7, 2012 at 3:27 PM, Daniel Stone wrote: > Hi, > > On 7 March 2012 22:21, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and simulate > > events using states 2 and 3 for repeat-up and repeat-down events. > > Did you think about just using a single event,

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-07 Thread Daniel Stone
Hi, On 7 March 2012 22:21, Scott Moreau wrote: > There's nothing fancy about this, we just set a timer and simulate > events using states 2 and 3 for repeat-up and repeat-down events. Did you think about just using a single event, rather than the separate repeat press/release events? If nothing

[RFC] compositor: Simple key repeat implementation.

2012-03-07 Thread Scott Moreau
There's nothing fancy about this, we just set a timer and simulate events using states 2 and 3 for repeat-up and repeat-down events. --- src/compositor.c | 72 ++ src/compositor.h |5 +++ 2 files changed, 77 insertions(+), 0 deletions(-) d