Re: [RFC] Plane color pipeline KMS uAPI

2023-06-16 Thread Pekka Paalanen
On Thu, 15 Jun 2023 17:44:33 -0400 Christopher Braga wrote: > On 6/14/2023 5:00 AM, Pekka Paalanen wrote: > > On Tue, 13 Jun 2023 12:29:55 -0400 > > Christopher Braga wrote: > > > >> On 6/13/2023 4:23 AM, Pekka Paalanen wrote: > >>> On Mon, 12 Jun 2023 12:56:57 -0400 > >>> Christopher Braga

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-15 Thread Christopher Braga
On 6/14/2023 5:00 AM, Pekka Paalanen wrote: On Tue, 13 Jun 2023 12:29:55 -0400 Christopher Braga wrote: On 6/13/2023 4:23 AM, Pekka Paalanen wrote: On Mon, 12 Jun 2023 12:56:57 -0400 Christopher Braga wrote: On 6/12/2023 5:21 AM, Pekka Paalanen wrote: On Fri, 9 Jun 2023 19:11:25 -04

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-14 Thread Pekka Paalanen
On Tue, 13 Jun 2023 12:29:55 -0400 Christopher Braga wrote: > On 6/13/2023 4:23 AM, Pekka Paalanen wrote: > > On Mon, 12 Jun 2023 12:56:57 -0400 > > Christopher Braga wrote: > > > >> On 6/12/2023 5:21 AM, Pekka Paalanen wrote: > >>> On Fri, 9 Jun 2023 19:11:25 -0400 > >>> Christopher Braga

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-13 Thread Christopher Braga
On 6/13/2023 4:23 AM, Pekka Paalanen wrote: On Mon, 12 Jun 2023 12:56:57 -0400 Christopher Braga wrote: On 6/12/2023 5:21 AM, Pekka Paalanen wrote: On Fri, 9 Jun 2023 19:11:25 -0400 Christopher Braga wrote: On 6/9/2023 12:30 PM, Simon Ser wrote: Hi Christopher, On Friday, June 9th,

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-13 Thread Pekka Paalanen
On Mon, 12 Jun 2023 12:56:57 -0400 Christopher Braga wrote: > On 6/12/2023 5:21 AM, Pekka Paalanen wrote: > > On Fri, 9 Jun 2023 19:11:25 -0400 > > Christopher Braga wrote: > > > >> On 6/9/2023 12:30 PM, Simon Ser wrote: > >>> Hi Christopher, > >>> > >>> On Friday, June 9th, 2023 at 17:52,

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-12 Thread Christopher Braga
On 6/12/2023 5:21 AM, Pekka Paalanen wrote: On Fri, 9 Jun 2023 19:11:25 -0400 Christopher Braga wrote: On 6/9/2023 12:30 PM, Simon Ser wrote: Hi Christopher, On Friday, June 9th, 2023 at 17:52, Christopher Braga wrote: The new COLOROP objects also expose a number of KMS properties.

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-12 Thread Pekka Paalanen
On Fri, 9 Jun 2023 19:11:25 -0400 Christopher Braga wrote: > On 6/9/2023 12:30 PM, Simon Ser wrote: > > Hi Christopher, > > > > On Friday, June 9th, 2023 at 17:52, Christopher Braga > > wrote: > > > >>> The new COLOROP objects also expose a number of KMS properties. Each has a > >>> type, a

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-12 Thread Christopher Braga
Hi all, The goal of this RFC is to expose a generic KMS uAPI to configure the color pipeline before blending, ie. after a pixel is tapped from a plane's framebuffer and before it's blended with other planes. With this new uAPI we aim to reduce the battery life impact of color management and HDR

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-12 Thread Christopher Braga
On 6/9/2023 12:30 PM, Simon Ser wrote: Hi Christopher, On Friday, June 9th, 2023 at 17:52, Christopher Braga wrote: The new COLOROP objects also expose a number of KMS properties. Each has a type, a reference to the next COLOROP object in the linked list, and other type-specific propertie

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-09 Thread Simon Ser
Hi Christopher, On Friday, June 9th, 2023 at 17:52, Christopher Braga wrote: > > The new COLOROP objects also expose a number of KMS properties. Each has a > > type, a reference to the next COLOROP object in the linked list, and other > > type-specific properties. Here is an example for a 1D LU

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-12 Thread Karol Herbst
On Wed, May 10, 2023 at 9:59 AM Jonas Ådahl wrote: > > On Tue, May 09, 2023 at 08:22:30PM +, Simon Ser wrote: > > On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote: > > > > > There are also other vendor side effects to having this in userspace. > > > > > > Will the library have a loader?

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-12 Thread Pekka Paalanen
On Thu, 11 May 2023 19:29:27 + Simon Ser wrote: > On Thursday, May 11th, 2023 at 18:56, Joshua Ashton wrote: > > > When we are talking about being 'prescriptive' in the API, are we > > outright saying we don't want to support arbitrary 3D LUTs, or are we > > just offering certain algorithms

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Simon Ser
On Friday, May 5th, 2023 at 15:30, Joshua Ashton wrote: > > > AMD would expose the following objects and properties: > > > > > > Plane 10 > > > ├─ "type": immutable enum {Overlay, Primary, Cursor} = Primary > > > └─ "color_pipeline": enum {0, 42} = 0 > > > Color operation 42 (inpu

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Simon Ser
On Thursday, May 11th, 2023 at 18:56, Joshua Ashton wrote: > When we are talking about being 'prescriptive' in the API, are we > outright saying we don't want to support arbitrary 3D LUTs, or are we > just offering certain algorithms to be 'executed' for a plane/crtc/etc > in the atomic API? I am

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Jonas Ådahl
On Thu, May 11, 2023 at 04:56:47PM +, Joshua Ashton wrote: > When we are talking about being 'prescriptive' in the API, are we > outright saying we don't want to support arbitrary 3D LUTs, or are we > just offering certain algorithms to be 'executed' for a plane/crtc/etc > in the atomic API? I

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Joshua Ashton
When we are talking about being 'prescriptive' in the API, are we outright saying we don't want to support arbitrary 3D LUTs, or are we just offering certain algorithms to be 'executed' for a plane/crtc/etc in the atomic API? I am confused... There is so much stuff to do with color, that I don't t

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-10 Thread Pekka Paalanen
On Wed, 10 May 2023 09:59:21 +0200 Jonas Ådahl wrote: > On Tue, May 09, 2023 at 08:22:30PM +, Simon Ser wrote: > > On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote: > > > > > There are also other vendor side effects to having this in userspace. > > > > > > Will the library have a lo

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-10 Thread Pekka Paalanen
On Tue, 09 May 2023 20:22:30 + Simon Ser wrote: > On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote: > > > There are also other vendor side effects to having this in userspace. > > > > Will the library have a loader? > > Will it allow proprietary plugins? > > Will it allow proprietary

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-10 Thread Melissa Wen
On 05/05, Joshua Ashton wrote: > Some corrections and replies inline. > > On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote: > > > > On Thu, 04 May 2023 15:22:59 + > > Simon Ser wrote: > > > > > Hi all, > > > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the > > >

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-10 Thread Jonas Ådahl
On Tue, May 09, 2023 at 08:22:30PM +, Simon Ser wrote: > On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote: > > > There are also other vendor side effects to having this in userspace. > > > > Will the library have a loader? > > Will it allow proprietary plugins? > > Will it allow proprie

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Simon Ser
On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote: > There are also other vendor side effects to having this in userspace. > > Will the library have a loader? > Will it allow proprietary plugins? > Will it allow proprietary reimplementations? > What will happen when a vendor wants distros to

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Dave Airlie
On Wed, 10 May 2023 at 00:31, Harry Wentland wrote: > > > > On 5/7/23 19:14, Dave Airlie wrote: > > On Sat, 6 May 2023 at 08:21, Sebastian Wick > > wrote: > >> > >> On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > >>> > >>> On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > Hi all

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Melissa Wen
On 05/09, Pekka Paalanen wrote: > On Tue, 9 May 2023 10:23:49 -0100 > Melissa Wen wrote: > > > On 05/05, Joshua Ashton wrote: > > > Some corrections and replies inline. > > > > > > On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote: > > > > > > > > On Thu, 04 May 2023 15:22:59 + > > > > Si

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Harry Wentland
On 5/7/23 19:14, Dave Airlie wrote: > On Sat, 6 May 2023 at 08:21, Sebastian Wick wrote: >> >> On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: >>> >>> On Fri, 5 May 2023 at 01:23, Simon Ser wrote: Hi all, The goal of this RFC is to expose a generic KMS uAPI to configure

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Pekka Paalanen
On Tue, 9 May 2023 10:23:49 -0100 Melissa Wen wrote: > On 05/05, Joshua Ashton wrote: > > Some corrections and replies inline. > > > > On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote: > > > > > > On Thu, 04 May 2023 15:22:59 + > > > Simon Ser wrote: > > > ... > > > > Color oper

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Pekka Paalanen
On Mon, 8 May 2023 18:54:09 -0500 Steven Kucharzyk wrote: > I'd like to ask if there is a block/flow chart/diagram that has been > created that represent the elements that are being discussed for this > RFC? If so, would you be so kind as to point me to it or send it to me? Hi Steven, the whole

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-09 Thread Pekka Paalanen
On Thu, 04 May 2023 15:22:59 + Simon Ser wrote: > Hi all, > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > pipeline before blending, ie. after a pixel is tapped from a plane's > framebuffer and before it's blended with other planes. With this new uAPI we > ai

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Steven Kucharzyk
On Mon, 08 May 2023 08:58:37 + Simon Ser wrote: > On Friday, May 5th, 2023 at 21:53, Daniel Vetter > wrote: > > > On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: > > > On Friday, May 5th, 2023 at 17:28, Daniel Vetter > > > wrote: > > > > > > > Ok no comments from me on the actua

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Harry Wentland
On 5/8/23 05:18, Daniel Vetter wrote: > On Mon, 8 May 2023 at 10:58, Simon Ser wrote: >> >> On Friday, May 5th, 2023 at 21:53, Daniel Vetter wrote: >> >>> On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > Ok no c

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Jonas Ådahl
On Mon, May 08, 2023 at 09:14:18AM +1000, Dave Airlie wrote: > On Sat, 6 May 2023 at 08:21, Sebastian Wick wrote: > > > > On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > > > > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > > > > > Hi all, > > > > > > > > The goal of this RFC is t

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Pekka Paalanen
On Mon, 8 May 2023 09:14:18 +1000 Dave Airlie wrote: > On Sat, 6 May 2023 at 08:21, Sebastian Wick wrote: > > > > On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > > > > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > > > > > Hi all, > > > > > > > > The goal of this RFC is to

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Daniel Vetter
On Mon, 8 May 2023 at 10:58, Simon Ser wrote: > > On Friday, May 5th, 2023 at 21:53, Daniel Vetter wrote: > > > On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: > > > On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > > > > > > > Ok no comments from me on the actual color operat

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Daniel Vetter
On Mon, 8 May 2023 at 10:24, Pekka Paalanen wrote: > > On Fri, 5 May 2023 21:51:41 +0200 > Daniel Vetter wrote: > > > On Fri, May 05, 2023 at 05:57:37PM +0200, Sebastian Wick wrote: > > > On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > > > > > > > On Thu, May 04, 2023 at 03:22:59PM +

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Simon Ser
On Friday, May 5th, 2023 at 21:53, Daniel Vetter wrote: > On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: > > On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > > > > > Ok no comments from me on the actual color operations and semantics of all > > > that, because I have simply

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Pekka Paalanen
On Fri, 5 May 2023 16:04:35 -0500 Steven Kucharzyk wrote: > Hi, > > I'm new to this list and probably can't contribute but interested, I > passed your original posting to a friend and have enclosed his thoughts > ... old hash or food for thought ??? I ask your forgiveness if you find > this inap

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Pekka Paalanen
On Fri, 5 May 2023 21:51:41 +0200 Daniel Vetter wrote: > On Fri, May 05, 2023 at 05:57:37PM +0200, Sebastian Wick wrote: > > On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > > > > > On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > > > > Hi all, > > > > > > > > The goal of

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-07 Thread Dave Airlie
On Sat, 6 May 2023 at 08:21, Sebastian Wick wrote: > > On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > > > Hi all, > > > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the > > > color > > > pipeline before

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Sebastian Wick
On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is tapped from a plane's > > framebuffer and bef

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Steven Kucharzyk
Hi, I'm new to this list and probably can't contribute but interested, I passed your original posting to a friend and have enclosed his thoughts ... old hash or food for thought ??? I ask your forgiveness if you find this inappropriate. (am of the elk * act first, ask for forgiveness afterward) ;

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Dave Airlie
On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > Hi all, > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > pipeline before blending, ie. after a pixel is tapped from a plane's > framebuffer and before it's blended with other planes. With this new uAPI we > aim to r

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Daniel Vetter
On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: > On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > > > Ok no comments from me on the actual color operations and semantics of all > > that, because I have simply nothing to bring to that except confusion :-) > > > > Some higher

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Daniel Vetter
On Fri, May 05, 2023 at 05:57:37PM +0200, Sebastian Wick wrote: > On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > > > On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > > > Hi all, > > > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the > > > color > >

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Joshua Ashton
On 5/5/23 15:16, Pekka Paalanen wrote: On Fri, 5 May 2023 14:30:11 +0100 Joshua Ashton wrote: Some corrections and replies inline. On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote: On Thu, 04 May 2023 15:22:59 + Simon Ser wrote: ... To wrap things up, let's take a real-world e

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Simon Ser
On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > Ok no comments from me on the actual color operations and semantics of all > that, because I have simply nothing to bring to that except confusion :-) > > Some higher level thoughts instead: > > - I really like that we just go with graph

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Sebastian Wick
On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is tapped from a plane's > > framebuffe

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Daniel Vetter
On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > Hi all, > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > pipeline before blending, ie. after a pixel is tapped from a plane's > framebuffer and before it's blended with other planes. With this new uAPI we

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Pekka Paalanen
On Fri, 5 May 2023 14:30:11 +0100 Joshua Ashton wrote: > Some corrections and replies inline. > > On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote: > > > > On Thu, 04 May 2023 15:22:59 + > > Simon Ser wrote: ... > > > To wrap things up, let's take a real-world example: how would gamesco

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Joshua Ashton
Some corrections and replies inline. On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote: > > On Thu, 04 May 2023 15:22:59 + > Simon Ser wrote: > > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is t

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Pekka Paalanen
On Thu, 04 May 2023 15:22:59 + Simon Ser wrote: > Hi all, > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > pipeline before blending, ie. after a pixel is tapped from a plane's > framebuffer and before it's blended with other planes. With this new uAPI we > ai

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-04 Thread Harry Wentland
On 5/4/23 11:22, Simon Ser wrote: Hi all, The goal of this RFC is to expose a generic KMS uAPI to configure the color pipeline before blending, ie. after a pixel is tapped from a plane's framebuffer and before it's blended with other planes. With this new uAPI we aim to reduce the battery lif

[RFC] Plane color pipeline KMS uAPI

2023-05-04 Thread Simon Ser
Hi all, The goal of this RFC is to expose a generic KMS uAPI to configure the color pipeline before blending, ie. after a pixel is tapped from a plane's framebuffer and before it's blended with other planes. With this new uAPI we aim to reduce the battery life impact of color management and HDR on