Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-30 Thread Daniel Stone
Hi, On 26 November 2015 at 14:47, Nils Chr. Brause wrote: > On Wed, Nov 25, 2015 at 10:01 PM, Bryce Harrington > wrote: >> On Wed, Nov 25, 2015 at 03:25:55PM +, Daniel Stone wrote: >>> Sure, we can fix Weston, and with a strict version requirement on the >>> protocol, we can make sure it doe

Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-26 Thread Nils Chr. Brause
Hi, On Wed, Nov 25, 2015 at 10:01 PM, Bryce Harrington wrote: > On Wed, Nov 25, 2015 at 03:25:55PM +, Daniel Stone wrote: >> Hi, >> >> On 25 November 2015 at 14:17, Auke Booij wrote: >> > On 25 November 2015 at 13:43, Daniel Stone wrote: >> >> Warnings aren't harmless though; there's a reas

Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-25 Thread Bryce Harrington
On Wed, Nov 25, 2015 at 03:25:55PM +, Daniel Stone wrote: > Hi, > > On 25 November 2015 at 14:17, Auke Booij wrote: > > On 25 November 2015 at 13:43, Daniel Stone wrote: > >> Warnings aren't harmless though; there's a reason we don't (shouldn't) > >> have any in our build. Every 'oh, just ig

Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-25 Thread Daniel Stone
Hi, On 25 November 2015 at 14:17, Auke Booij wrote: > On 25 November 2015 at 13:43, Daniel Stone wrote: >> Warnings aren't harmless though; there's a reason we don't (shouldn't) >> have any in our build. Every 'oh, just ignore that' warning drowns out >> legitimate compiler warnings, and dumping

Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-25 Thread Auke Booij
On 25 November 2015 at 13:43, Daniel Stone wrote: > Hi, > > On 25 November 2015 at 12:08, Nils Christopher Brause > wrote: >> 3. The API change is negligible. Every request that accepts this bitfield >>expects a number in the range of zero to seven. These numbers can be >>represented in a

Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-25 Thread Daniel Stone
Hi, On 25 November 2015 at 12:08, Nils Christopher Brause wrote: > 3. The API change is negligible. Every request that accepts this bitfield >expects a number in the range of zero to seven. These numbers can be >represented in and converted between signed and unsigned 32 bit integers >

[RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-25 Thread Nils Christopher Brause
The definition of a bitfield is that each bit has a distinct meaning, which is the case for the enumeration wl_output.transform: - bit 0: rotate by 90 degree - bit 1: rotate by 180 degree - bit 2: flip around vertical axis Every other value can be constructed by ORing together the above bits: -