Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Jonas Ådahl
On Wed, Apr 18, 2018 at 03:53:31PM +0300, Pekka Paalanen wrote: > On Wed, 18 Apr 2018 08:21:29 -0400 > Drew DeVault wrote: > > > Replying to everyone. > > > > On 2018-04-18 5:32 AM, Simon Ser wrote: > > > I agree with Jonas here. Maybe we could add two fields: > > > > > > - "codename", restric

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Pekka Paalanen
On Wed, 18 Apr 2018 08:21:29 -0400 Drew DeVault wrote: > Replying to everyone. > > On 2018-04-18 5:32 AM, Simon Ser wrote: > > I agree with Jonas here. Maybe we could add two fields: > > > > - "codename", restricted to alphanumeric + hyphens characters (to reflect > > the > > current inform

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Drew DeVault
Replying to everyone. On 2018-04-18 5:32 AM, Simon Ser wrote: > I agree with Jonas here. Maybe we could add two fields: > > - "codename", restricted to alphanumeric + hyphens characters (to reflect the > current informal practice to name outputs like "VGA-1"), specified to be > unique and pe

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Simon Ser
On April 18, 2018 9:57 AM, Jonas Ådahl wrote: > Replying to both Pekka and Drew at the same time here: > > On Mon, Apr 16, 2018 at 11:14:51AM -0400, Drew DeVault wrote: > > On 2018-04-16 2:57 PM, Jonas Ådahl wrote: > > > I'd still like a bit more clarification about what to expect of this > > >

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Jonas Ådahl
Replying to both Pekka and Drew at the same time here: On Mon, Apr 16, 2018 at 11:14:51AM -0400, Drew DeVault wrote: > On 2018-04-16 2:57 PM, Jonas Ådahl wrote: > > I'd still like a bit more clarification about what to expect of this > > string. What I'm trying to avoid is one compositor sending

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Pekka Paalanen
On Mon, 16 Apr 2018 11:14:51 -0400 Drew DeVault wrote: > On 2018-04-16 2:57 PM, Jonas Ådahl wrote: > > I'd still like a bit more clarification about what to expect of this > > string. What I'm trying to avoid is one compositor sending "eDP-1" while > > another sends "Built-in Display". For examp

Re: [PATCHv4] Add name event to xdg-output

2018-04-18 Thread Pekka Paalanen
On Mon, 16 Apr 2018 08:40:52 -0400 Drew DeVault wrote: > On 2018-04-16 10:53 AM, Pekka Paalanen wrote: > > That's very clear, but is it precisely your intention? Would it make > > more sense to define that the name does not change during the lifetime > > of the wl_output global instead? That woul

Re: [PATCHv4] Add name event to xdg-output

2018-04-16 Thread Drew DeVault
On 2018-04-16 2:57 PM, Jonas Ådahl wrote: > I'd still like a bit more clarification about what to expect of this > string. What I'm trying to avoid is one compositor sending "eDP-1" while > another sends "Built-in Display". For example, the first is suitable for > command line interfaces (e.g. mov

Re: [PATCHv4] Add name event to xdg-output

2018-04-16 Thread Jonas Ådahl
On Sat, Apr 14, 2018 at 10:15:08AM -0400, Drew DeVault wrote: > Signed-off-by: Drew DeVault > Reviewed-by: Simon Ser > --- > This revision addresses Pekka's feedback, specifying that the output > name will not change over the lifetime of the xdg_output. This also > answers a question from an earl

Re: [PATCHv4] Add name event to xdg-output

2018-04-16 Thread Drew DeVault
On 2018-04-16 10:53 AM, Pekka Paalanen wrote: > That's very clear, but is it precisely your intention? Would it make > more sense to define that the name does not change during the lifetime > of the wl_output global instead? That would guarantee that the name > will stay the same for the same wl_ou

Re: [PATCHv4] Add name event to xdg-output

2018-04-16 Thread Pekka Paalanen
Hi, one elementary detail I have missed is that you have no commit message. For the record, you should give a justification for why xdg_output needs a name event added. On Sat, 14 Apr 2018 10:15:08 -0400 Drew DeVault wrote: > Signed-off-by: Drew DeVault > Reviewed-by: Simon Ser > --- > This

[PATCHv4] Add name event to xdg-output

2018-04-14 Thread Drew DeVault
Signed-off-by: Drew DeVault Reviewed-by: Simon Ser --- This revision addresses Pekka's feedback, specifying that the output name will not change over the lifetime of the xdg_output. This also answers a question from an earlier email: On 2018-04-11 11:02 AM, Pekka Paalanen wrote: > There is still