Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-21 Thread Marek Chalupa
Hi, On Thu, May 14, 2015 at 6:37 PM, Dima Ryazanov wrote: > Oh wow, I was playing around with outputs, and never realized > output_handle_done > was being called after any geometry change, not just after the output was > created. > > On Thu, May 14, 2015 at 2:58 AM, Marek Chalupa > wrote: > >>

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-21 Thread Marek Chalupa
On Thu, May 14, 2015 at 6:43 PM, Dima Ryazanov wrote: > Actually, why not just move "xorg_list_append(&xwl_output->link, > &xwl_screen->output_list);" to xwl_output_create? > I'm not an expert on output, but I think that it is in output.done on purpose. output.done was added to allow "atomic" up

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-15 Thread Dima Ryazanov
I just made that change in my set of patches, and I think it fixes the problem. On Thu, May 14, 2015 at 9:43 AM, Dima Ryazanov wrote: > Actually, why not just move "xorg_list_append(&xwl_output->link, > &xwl_screen->output_list);" to xwl_output_create? > > I can't tell if there's a reason it's i

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-14 Thread Dima Ryazanov
Actually, why not just move "xorg_list_append(&xwl_output->link, &xwl_screen->output_list);" to xwl_output_create? I can't tell if there's a reason it's in xwl_output_done, or if it's just an oversight. On Thu, May 14, 2015 at 9:37 AM, Dima Ryazanov wrote: > Oh wow, I was playing around with ou

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-14 Thread Dima Ryazanov
Oh wow, I was playing around with outputs, and never realized output_handle_done was being called after any geometry change, not just after the output was created. On Thu, May 14, 2015 at 2:58 AM, Marek Chalupa wrote: > output.done event can be sent even on some property change, not only > when

[PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-14 Thread Marek Chalupa
output.done event can be sent even on some property change, not only when announcing the output. Therefore we must check if we already have it otherwise we may corrupt the list by adding it multiple times. This fixes bug when xwayland looped indefinitely in output.done handler and that can be repr