Re: [PATCH xwayland] Set the view to NULL when unmapping an X11 window

2013-11-15 Thread Axel Davy
I've looked deeply in the code to find the remaining xwayland bugs. I'll publish later a fix for these. The remaining bugs are due to accessing to the frame field on unmapped windows. Your patch solves all the issues with the view field. Your patch is tested and Reviewed-by: Axel Davy Axel

Re: [PATCH xwayland] Set the view to NULL when unmapping an X11 window

2013-11-15 Thread Dima Ryazanov
Oh interesting... I can fix the crash by checking for a NULL pointer, though I don't know if that's the proper fix. Anyways, I'll send out the new patches. On Fri, Nov 15, 2013 at 12:44 AM, Axel Davy wrote: > I have tested your patch, but it doesn't solve all the bugs occuring in > XWayland be

Re: [PATCH xwayland] Set the view to NULL when unmapping an X11 window

2013-11-15 Thread Axel Davy
I have tested your patch, but it doesn't solve all the bugs occuring in XWayland because of views (take vlc, go to the menu, crash). It appears ok to me to set view to NULL at these locations, but there's probably something more to do. Axel Davy On 15/11/2013, Dima Ryazanov wrote : Ping :)

Re: [PATCH xwayland] Set the view to NULL when unmapping an X11 window

2013-11-14 Thread Dima Ryazanov
Ping :) On Fri, Nov 1, 2013 at 12:46 AM, Dima Ryazanov wrote: > Fixes a crash caused by accessing a deleted view in > weston_wm_window_schedule_repaint. It can be easily reproduced by switching > between menus in Firefox. > > Signed-off-by: Dima Ryazanov > --- > src/xwayland/window-manager.c

[PATCH xwayland] Set the view to NULL when unmapping an X11 window

2013-11-01 Thread Dima Ryazanov
Fixes a crash caused by accessing a deleted view in weston_wm_window_schedule_repaint. It can be easily reproduced by switching between menus in Firefox. Signed-off-by: Dima Ryazanov --- src/xwayland/window-manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xwayland/window-man