Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-18 Thread Pekka Paalanen
On Thu, 12 Apr 2018 14:58:13 +0200 Daniel Stone wrote: > Hi Pekka, > > On 12 April 2018 at 14:53, Pekka Paalanen wrote: > > On Thu, 12 Apr 2018 15:37:43 +0300 Pekka Paalanen > > wrote: > >> On Thu, 12 Apr 2018 14:03:32 +0200 Daniel Stone > >> wrote: > >> > One thing I'm missing (possibl

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Daniel Stone
Hi Pekka, On 12 April 2018 at 14:53, Pekka Paalanen wrote: > On Thu, 12 Apr 2018 15:37:43 +0300 Pekka Paalanen wrote: >> On Thu, 12 Apr 2018 14:03:32 +0200 Daniel Stone wrote: >> > One thing I'm missing (possibly post-lunch tiredness, but): when >> > exactly would we replace a connector? Is it

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Pekka Paalanen
On Thu, 12 Apr 2018 15:37:43 +0300 Pekka Paalanen wrote: > On Thu, 12 Apr 2018 14:03:32 +0200 > Daniel Stone wrote: > > > Hi Pekka, > > I've reviewed up to this point (the first half as discussed before, > > second half from this submission), and it all looks good so far. One > > question: > >

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Pekka Paalanen
On Thu, 12 Apr 2018 14:03:32 +0200 Daniel Stone wrote: > Hi Pekka, > I've reviewed up to this point (the first half as discussed before, > second half from this submission), and it all looks good so far. One > question: > > On 16 February 2018 at 15:57, Pekka Paalanen wrote: > > +/** Replace co

Re: [PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-04-12 Thread Daniel Stone
Hi Pekka, I've reviewed up to this point (the first half as discussed before, second half from this submission), and it all looks good so far. One question: On 16 February 2018 at 15:57, Pekka Paalanen wrote: > +/** Replace connector data and monitor information > + * > + * @param head The head t

[PATCH weston v6 49/73] compositor-drm: move connector fields into drm_head

2018-02-16 Thread Pekka Paalanen
From: Pekka Paalanen Move the connector related fields from drm_output to the drm_head. A drm_head represents a connector for now. The code in drm_head_create() to update connector data, monitor information, etc. is moved into a new function. This will be useful when DRM-backend starts creating