Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Pekka Paalanen
On Mon, 23 Oct 2017 13:06:19 +0200 Daniel Stone wrote: > Hi, > > On 12 October 2017 at 13:13, Emre Ucan wrote: > > +static void > > +list_scope_begin(struct weston_debug_stream *stream, void *user_data) > > +{ > > + struct weston_debug_compositor *wdc = user_data; > > + struct westo

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hey, One last comment from IRC discussion. On 23 October 2017 at 13:10, Daniel Stone wrote: > On 23 October 2017 at 12:54, Pekka Paalanen wrote: >> On Mon, 23 Oct 2017 12:34:47 +0200 >> Daniel Stone wrote: >>> I would very much not like to see formatted time in the debug scopes. >>> Can we plea

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hey, On 23 October 2017 at 12:54, Pekka Paalanen wrote: > On Mon, 23 Oct 2017 12:34:47 +0200 > Daniel Stone wrote: >> On 12 October 2017 at 13:13, Emre Ucan wrote: >> > + gettimeofday(&tv, NULL); >> > + >> > + bdt = localtime(&tv.tv_sec); >> > + if (bdt) >> > + r

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hi, On 12 October 2017 at 13:13, Emre Ucan wrote: > +static void > +list_scope_begin(struct weston_debug_stream *stream, void *user_data) > +{ > + struct weston_debug_compositor *wdc = user_data; > + struct weston_debug_scope *scope; > + > + weston_debug_stream_printf(stream, "S

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Pekka Paalanen
On Mon, 23 Oct 2017 12:34:47 +0200 Daniel Stone wrote: > Hi, > > On 12 October 2017 at 13:13, Emre Ucan wrote: > > +WL_EXPORT char * > > +weston_debug_scope_timestamp(struct weston_debug_scope *scope, > > +char *buf, size_t len) > > +{ > > + struct timeval tv;

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hi, On 12 October 2017 at 13:13, Emre Ucan wrote: > +WL_EXPORT char * > +weston_debug_scope_timestamp(struct weston_debug_scope *scope, > +char *buf, size_t len) > +{ > + struct timeval tv; > + struct tm *bdt; > + char string[128]; > + size_t re

[PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-12 Thread Emre Ucan
From: Pekka Paalanen weston_debug is both a libweston API for relaying debugging messages, and the compositor-debug wayland protocol implementation for accessing those debug messages from a Wayland client. weston_debug_compositor_{create,destroy}() are private API, hence not exported. Signed-of