Re: [PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-12 Thread Pekka Paalanen
On Tue, 11 Nov 2014 16:10:22 +0200 Giulio Camuffo wrote: > 2014-11-11 15:10 GMT+02:00 Pekka Paalanen : > > On Tue, 11 Nov 2014 11:23:40 +0200 > > Giulio Camuffo wrote: > > > >> weston key bindings are supposed to eat the key events, and not pass it > >> on to clients, and indeed the wl_keyboard.

Re: [PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
2014-11-11 15:10 GMT+02:00 Pekka Paalanen : > On Tue, 11 Nov 2014 11:23:40 +0200 > Giulio Camuffo wrote: > >> weston key bindings are supposed to eat the key events, and not pass it >> on to clients, and indeed the wl_keyboard.key event is not sent. But >> we must also not put the key in the keys

Re: [PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Pekka Paalanen
On Tue, 11 Nov 2014 11:23:40 +0200 Giulio Camuffo wrote: > weston key bindings are supposed to eat the key events, and not pass it > on to clients, and indeed the wl_keyboard.key event is not sent. But > we must also not put the key in the keys array to pass to client with > the wl_keyboard.enter

[PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else we may send the 'eaten' one too. In the case of a k

[PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else we may send the 'eaten' one too. In the case of a k