Re: [PATCH weston v4] compositor-drm: Ignore non-KMS devices

2017-02-14 Thread Daniel Stone
Hi Emil, On 14 February 2017 at 09:48, Daniel Stone wrote: > On 13 February 2017 at 23:42, Emil Velikov wrote: >> Thinking about this a bit more this won't fly either, I'm afraid. In >> the previous version we'll keep potentially old/unwanted device open, >> leaking. While this this version we'l

Re: [PATCH weston v4] compositor-drm: Ignore non-KMS devices

2017-02-14 Thread Daniel Stone
Hi Emil, On 13 February 2017 at 23:42, Emil Velikov wrote: > On 13 February 2017 at 18:57, Daniel Stone wrote: >> /* >> * Find primary GPU >> * Some systems may have multiple DRM devices attached to a single seat. >> This > Completely forgot: we want to update the comment above the functio

Re: [PATCH weston v4] compositor-drm: Ignore non-KMS devices

2017-02-13 Thread Emil Velikov
On 13 February 2017 at 18:57, Daniel Stone wrote: > /* > * Find primary GPU > * Some systems may have multiple DRM devices attached to a single seat. This Completely forgot: we want to update the comment above the function. > + /* Make sure this device is actually capable of m

[PATCH weston v4] compositor-drm: Ignore non-KMS devices

2017-02-13 Thread Daniel Stone
Given that we can have render-only devices, or vgem in a class of its own, ignore any non-KMS devices in compositor-drm's device selection. For x86 platforms, this is mostly a non-issue since we look at the udev boot_vga issue, but other architectures which lack this, and have multiple KMS devices