Re: Release blocker (Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer)

2015-05-24 Thread Pekka Paalanen
Hi, I confirm the out-of-tree test error is now fixed, thanks! On Fri, 22 May 2015 19:19:46 -0700 Bryce Harrington wrote: > On Fri, May 22, 2015 at 10:34:00AM +0300, Pekka Paalanen wrote: > > > > Another failure: > > > > $ make check TESTS=internal-screenshot.weston > > WESTON_TEST_REFERENC

Re: Release blocker (Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer)

2015-05-22 Thread Bryce Harrington
On Fri, May 22, 2015 at 10:34:00AM +0300, Pekka Paalanen wrote: > > Another failure: > > $ make check TESTS=internal-screenshot.weston > WESTON_TEST_REFERENCE_PATH=~/git/weston/tests/reference BACKEND=x11-backend.so > > FAIL: internal-screenshot.weston > test-client: got seat 0x73a6e0 capabilit

Re: Release blocker (Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer)

2015-05-22 Thread Bryce Harrington
On Fri, May 22, 2015 at 03:27:39PM -0500, Derek Foreman wrote: > On 22/05/15 02:34 AM, Pekka Paalanen wrote: > > Another failure: > > > > $ make check TESTS=internal-screenshot.weston > > WESTON_TEST_REFERENCE_PATH=~/git/weston/tests/reference > > BACKEND=x11-backend.so > > > > FAIL: internal-s

Re: Release blocker (Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer)

2015-05-22 Thread Derek Foreman
On 22/05/15 02:34 AM, Pekka Paalanen wrote: > On Thu, 21 May 2015 15:43:18 -0700 > Bryce Harrington wrote: > >> On Thu, May 21, 2015 at 04:44:41PM -0500, Derek Foreman wrote: >>> With the tiny stride change mentioned on IRC, which, for those that >>> weren't present, was basically little more tha

Release blocker (Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer)

2015-05-22 Thread Pekka Paalanen
On Thu, 21 May 2015 15:43:18 -0700 Bryce Harrington wrote: > On Thu, May 21, 2015 at 04:44:41PM -0500, Derek Foreman wrote: > > With the tiny stride change mentioned on IRC, which, for those that > > weren't present, was basically little more than: > > if (stride != bpp * reference->width) FAIL >

Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer

2015-05-21 Thread Bryce Harrington
On Thu, May 21, 2015 at 04:44:41PM -0500, Derek Foreman wrote: > With the tiny stride change mentioned on IRC, which, for those that > weren't present, was basically little more than: > if (stride != bpp * reference->width) FAIL > in load_surface_from_png() > > for the series: > Reviewed-By: Derek

Re: [PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer

2015-05-21 Thread Derek Foreman
With the tiny stride change mentioned on IRC, which, for those that weren't present, was basically little more than: if (stride != bpp * reference->width) FAIL in load_surface_from_png() for the series: Reviewed-By: Derek Foreman On 21/05/15 03:39 AM, Bryce Harrington wrote: > Thought I'd try o

[PATCH weston v3 00/15] Implement screenshot-based testing with the headless renderer

2015-05-21 Thread Bryce Harrington
Thought I'd try one last run at the football... This series adds support for implementing test cases that can check rendering output without needing connection to a physical output. It utilizes the pixman renderer in the headless backend to generate screenshots at the request of the test client.