Re: [PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-11 Thread Pekka Paalanen
On Tue, 10 Mar 2015 13:46:43 -0700 Jason Ekstrand wrote: > Hey pq, > Glad to see this stuff finally look like landing ~1 year later. :-) My > reviewing ability on this code has decreased substantially since I wrote it > so I'm kind of trusting you to have tested it thuroughly and trusting > myse

Re: [PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-10 Thread Bill Spitzak
Yea looks like you are right. I thought the matrix in the vertex shader was a final output one, but it is instead the projection to clipping space. I would suspect even if you could mess with whatever is done to convert clipping space to pixel space would just make it clip at the wrong location

Re: [PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-10 Thread Jason Ekstrand
Hey pq, Glad to see this stuff finally look like landing ~1 year later. :-) My reviewing ability on this code has decreased substantially since I wrote it so I'm kind of trusting you to have tested it thuroughly and trusting myself to have known what I was doing back then. That said, Reviewed-by

Re: [PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-10 Thread Jason Ekstrand
On Tue, Mar 10, 2015 at 12:51 PM, Bill Spitzak wrote: > This all looks really good to me. > > It is possible to avoid "GL coordinates" even in GL. Set the projection > matrix to an ortho matrix: > > glMatrixMode(GL_PROJECTION); > glLoadIdentity() > glOrtho(0, width, height, 0, -1, 1); > g

Re: [PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-10 Thread Bill Spitzak
This all looks really good to me. It is possible to avoid "GL coordinates" even in GL. Set the projection matrix to an ortho matrix: glMatrixMode(GL_PROJECTION); glLoadIdentity() glOrtho(0, width, height, 0, -1, 1); glTranslate(-width/2, -height/2, 0); glMatrixMode(GL_MODELVIEW); I

Re: [PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-10 Thread Derek Foreman
On 10/03/15 08:01 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > as requested by Derek, here is a revised series from > http://lists.freedesktop.org/archives/wayland-devel/2015-March/020440.html > > The major addition to the series is that I pulled selected patches from > http://l

[PATCH weston v2 00/16] Fix pixman-renderer cropping

2015-03-10 Thread Pekka Paalanen
From: Pekka Paalanen Hi, as requested by Derek, here is a revised series from http://lists.freedesktop.org/archives/wayland-devel/2015-March/020440.html The major addition to the series is that I pulled selected patches from http://lists.freedesktop.org/archives/wayland-devel/2014-October/01780