Re: [PATCH weston v2] xwayland: Fix crash when run with no input device

2016-11-16 Thread Daniel Stone
Hi Tom, On 1 November 2016 at 19:14, Tom Hochstein wrote: > Starting an xterm with no input device led to a crash > because weston_wm_pick_seat() was returning garbage and > weston_wm_selection_init() was trying to use the garbage. > > Signed-off-by: Tom Hochstein > --- > v2: Don't call weston_w

Re: [PATCH weston v2] xwayland: Fix crash when run with no input device

2016-11-02 Thread Bryce Harrington
On Tue, Nov 01, 2016 at 02:14:00PM -0500, Tom Hochstein wrote: > Starting an xterm with no input device led to a crash > because weston_wm_pick_seat() was returning garbage and > weston_wm_selection_init() was trying to use the garbage. > > Signed-off-by: Tom Hochstein Reviewed-by: Bryce Harring

Re: [PATCH weston v2] xwayland: Fix crash when run with no input device

2016-11-02 Thread Giulio Camuffo
Hi, Looks good to me, Reviewed-by: Giulio Camuffo 2016-11-01 20:14 GMT+01:00 Tom Hochstein : > Starting an xterm with no input device led to a crash > because weston_wm_pick_seat() was returning garbage and > weston_wm_selection_init() was trying to use the garbage. > > Signed-off-by: Tom Hochst

[PATCH weston v2] xwayland: Fix crash when run with no input device

2016-11-01 Thread Tom Hochstein
Starting an xterm with no input device led to a crash because weston_wm_pick_seat() was returning garbage and weston_wm_selection_init() was trying to use the garbage. Signed-off-by: Tom Hochstein --- v2: Don't call weston_wm_set_selection if there is no seat xwayland/selection.c | 2 ++ x