Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

2016-11-21 Thread Daniel Stone
Hi, On 17 November 2016 at 14:41, Pekka Paalanen wrote: > On Thu, 17 Nov 2016 12:17:59 + > Daniel Stone wrote: >> @@ -148,13 +148,19 @@ bind_to_unix_socket(int display) >> static int >> create_lockfile(int display, char *lockfile, size_t lsize) >> { >> - char pid[16]; >> + /* 10 d

Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

2016-11-17 Thread Pekka Paalanen
On Thu, 17 Nov 2016 12:17:59 + Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has the effect of culling a

Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

2016-11-17 Thread Eric Engestrom
On Thursday, 2016-11-17 12:17:59 +, Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has the effect of cullin

[PATCH weston v2] xwayland: Fix X11 lock file size confusion

2016-11-17 Thread Daniel Stone
The X11 lock file was somewhat opaque. Into a sized array of 16 characters, we previously read 11 bytes. 61beda653b fixed the parsing of this input to ensure that we only considered the first 10 bytes: this has the effect of culling a LF byte at the end of the string. This commit more explicitly N