Re: [PATCH weston v2] weston.pc: Properly specify Requires.private

2016-05-04 Thread Daniel Stone
Hi, On 6 April 2016 at 13:09, Quentin Glidic wrote: > On 06/04/2016 08:39, Bryce Harrington wrote: >> One thing I wonder is if any of these might need to become a Require >> when we are providing a libweston library API? > > From [1] which references [2], a lot of pkg-config files are doing it wr

Re: [PATCH weston v2] weston.pc: Properly specify Requires.private

2016-04-06 Thread Bryce Harrington
On Wed, Apr 06, 2016 at 02:09:41PM +0200, Quentin Glidic wrote: > On 06/04/2016 08:39, Bryce Harrington wrote: > >[snip] > >One thing I wonder is if any of these might need to become a Require > >when we are providing a libweston library API? > > From [1] which references [2], a lot of pkg-config

Re: [PATCH weston v2] weston.pc: Properly specify Requires.private

2016-04-06 Thread Quentin Glidic
On 06/04/2016 08:39, Bryce Harrington wrote: [snip] One thing I wonder is if any of these might need to become a Require when we are providing a libweston library API? From [1] which references [2], a lot of pkg-config files are doing it wrong. Requires should only be used in rare cases (thoug

Re: [PATCH weston v2] weston.pc: Properly specify Requires.private

2016-04-05 Thread Bryce Harrington
On Tue, Apr 05, 2016 at 10:11:32AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > We include wayland-server.h, pixman.h and xkbcommon.h in compositor.h, > but they are not required for linking if the plugin doesn’t use them. > > Signed-off-by: Quentin Glidic On an initial readup of Re

[PATCH weston v2] weston.pc: Properly specify Requires.private

2016-04-05 Thread Quentin Glidic
From: Quentin Glidic We include wayland-server.h, pixman.h and xkbcommon.h in compositor.h, but they are not required for linking if the plugin doesn’t use them. Signed-off-by: Quentin Glidic --- v2: Was missing wayland-server src/weston.pc.in | 1 + 1 file changed, 1 insertion(+) diff --git