On Thu, 14 Apr 2016 14:53:12 +0300
Pekka Paalanen wrote:
> On Thu, 14 Apr 2016 11:25:47 +
> "Chokshi, Mitul" wrote:
>
> > Do we really need the git commit message (subject) in version string?
> > What if we use commit hash instead? That will be a simple solution of
> > replacing %s with %H
On Thu, 14 Apr 2016 11:25:47 +
"Chokshi, Mitul" wrote:
> Do we really need the git commit message (subject) in version string?
> What if we use commit hash instead? That will be a simple solution of
> replacing %s with %H i.e. git --git-dir=$(top_srcdir)/.git log -1
> --format='%H (%ci)'
I s
a Paalanen [mailto:ppaala...@gmail.com]
Sent: Wednesday, April 13, 2016 3:46 PM
To: Chokshi, Mitul
Cc: Bryce Harrington ; yba...@humanoriented.com;
wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH weston v2] Makefile: Fix compilation error when git commit
message has quotes
On Thu, 7 Apr 201
On Thu, 7 Apr 2016 10:56:23 -0700
Bryce Harrington wrote:
> On Thu, Apr 07, 2016 at 04:53:31PM +, Chokshi, Mitul wrote:
> >
> > A double-quote in log message prematurely ends the enquoted string
> > in src/git-version.h, causing an error during compilation.
> > Used stream editor to replace
On Thu, Apr 07, 2016 at 04:53:31PM +, Chokshi, Mitul wrote:
>
> A double-quote in log message prematurely ends the enquoted string
> in src/git-version.h, causing an error during compilation.
> Used stream editor to replace " with \"
>
> Signed-off-by: Mitul Chokshi
> ---
> Makefile.am | 2
A double-quote in log message prematurely ends the enquoted string
in src/git-version.h, causing an error during compilation.
Used stream editor to replace " with \"
Signed-off-by: Mitul Chokshi
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Ma
