Re: [PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-25 Thread Pekka Paalanen
On Tue, 25 Jul 2017 15:13:56 +0300 Pekka Paalanen wrote: > On Tue, 25 Jul 2017 11:50:58 +0100 > Daniel Stone wrote: > > > Hi, > > > > On 25 July 2017 at 11:28, Pekka Paalanen wrote: > > > On Mon, 24 Jul 2017 18:13:39 +0100 > > > Daniel Stone wrote: > > >> > I believe this should shorte

Re: [PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-25 Thread Pekka Paalanen
On Tue, 25 Jul 2017 11:50:58 +0100 Daniel Stone wrote: > Hi, > > On 25 July 2017 at 11:28, Pekka Paalanen wrote: > > On Mon, 24 Jul 2017 18:13:39 +0100 > > Daniel Stone wrote: > >> > I believe this should shorten to: "Call this for every DRM object > >> > individually once." > >> > > >> > Th

Re: [PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-25 Thread Daniel Stone
Hi, On 25 July 2017 at 11:28, Pekka Paalanen wrote: > On Mon, 24 Jul 2017 18:13:39 +0100 > Daniel Stone wrote: >> > I believe this should shorten to: "Call this for every DRM object >> > individually once." >> > >> > The language about status changes is probably a remnant of the value >> > cachi

Re: [PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-25 Thread Pekka Paalanen
On Mon, 24 Jul 2017 18:13:39 +0100 Daniel Stone wrote: > Hi Pekka, > I've made a mental note to make as careful passes over the > documentation as the code before I send for review ... > > On 19 July 2017 at 15:43, Pekka Paalanen wrote: > > On Tue, 18 Jul 2017 14:14:25 +0100 > > Daniel Stone w

Re: [PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-24 Thread Daniel Stone
Hi Pekka, I've made a mental note to make as careful passes over the documentation as the code before I send for review ... On 19 July 2017 at 15:43, Pekka Paalanen wrote: > On Tue, 18 Jul 2017 14:14:25 +0100 > Daniel Stone wrote: >> + /* Map from raw value to enum value */ >> +

Re: [PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-19 Thread Pekka Paalanen
On Tue, 18 Jul 2017 14:14:25 +0100 Daniel Stone wrote: > Add a cache for DRM property IDs and values, and use it for the two > connector properties we currently update: DPMS and EDID. > > As DRM property ID values are not stable, we need to do a name -> ID > lookup each run in order to discover

[PATCH weston v11 03/13] compositor-drm: Add DRM property cache

2017-07-18 Thread Daniel Stone
Add a cache for DRM property IDs and values, and use it for the two connector properties we currently update: DPMS and EDID. As DRM property ID values are not stable, we need to do a name -> ID lookup each run in order to discover the property IDs and enum values to use for those properties. Rathe