Re: [PATCH weston v1 3/3] compositor-x11: remove manual mouse button grab/ungrab

2016-05-18 Thread Benoit Gschwind
Hello Bill, You are right, thus I dug into the git history and I found that the grab is mostly to confine the cursor into the X11 window. For reference, the git commit id [1] and the related bug [2]. Since I do not want introduce a regression, I think the minor improvement is valid. Best regards

Re: [PATCH weston v1 3/3] compositor-x11: remove manual mouse button grab/ungrab

2016-05-16 Thread Bill Spitzak
Does the x11 compositor have to do this at all? It owns that window so it gets automatic grabs. This is for one client to eat the events being passed to another client. On Fri, May 13, 2016 at 4:34 AM, Benoit Gschwind wrote: > In current compositor-x11, the mouse buttons are grabbed and ungrabb

[PATCH weston v1 3/3] compositor-x11: remove manual mouse button grab/ungrab

2016-05-13 Thread Benoit Gschwind
In current compositor-x11, the mouse buttons are grabbed and ungrabbed manually that may produce weird cases like starting a grab while the buttons are already released, due to asynchronous X11 events dispatching. The patch avoid the issue by using the better passive button grab, that automaticall