Re: [PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-11 Thread Pekka Paalanen
On Thu, 10 Mar 2016 17:41:39 +0100 Armin Krezović wrote: > On 10.03.2016 12:37, Pekka Paalanen wrote: > > On Thu, 10 Mar 2016 01:58:15 +0100 > > Armin Krezović wrote: > > > >> On 09.03.2016 19:57, Bryce Harrington wrote: > >>> Hi Armin, > >>> > >>> This is coming along nicely, keep up the g

Re: [PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-10 Thread Armin Krezović
On 10.03.2016 12:37, Pekka Paalanen wrote: > On Thu, 10 Mar 2016 01:58:15 +0100 > Armin Krezović wrote: > >> On 09.03.2016 19:57, Bryce Harrington wrote: >>> Hi Armin, >>> >>> This is coming along nicely, keep up the good work. I'm going to follow >>> pq's lead here in pointing out more than I u

Re: [PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-10 Thread Pekka Paalanen
On Thu, 10 Mar 2016 01:58:15 +0100 Armin Krezović wrote: > On 09.03.2016 19:57, Bryce Harrington wrote: > > Hi Armin, > > > > This is coming along nicely, keep up the good work. I'm going to follow > > pq's lead here in pointing out more than I usually would, in interest of > > education. Than

Re: [PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-09 Thread Armin Krezović
On 09.03.2016 19:57, Bryce Harrington wrote: > Hi Armin, > > This is coming along nicely, keep up the good work. I'm going to follow > pq's lead here in pointing out more than I usually would, in interest of > education. > Hi Bryce, > On Tue, Mar 08, 2016 at 07:50:16PM +0100, Armin Krezović wr

Re: [PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-09 Thread Bryce Harrington
Hi Armin, This is coming along nicely, keep up the good work. I'm going to follow pq's lead here in pointing out more than I usually would, in interest of education. On Tue, Mar 08, 2016 at 07:50:16PM +0100, Armin Krezović wrote: > From: Armin Krezović This From line isn't needed in the commit

[PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-08 Thread Armin Krezović
From: Armin Krezović This patch enhances the panel clock by adding a config file option which can be used to either disable the clock or make it also show seconds in the current clock format. v2: Implement suggestions from Pekka's first review. v3: Implement suggestions from Pekka's second revie

[PATCH weston GSoC v3] desktop-shell: make panel clock configurable

2016-03-08 Thread Armin K
From: Armin Krezović This patch enhances the panel clock by adding a config file option which can be used to either disable the clock or make it also show seconds in the current clock format. v2: Implement suggestions from Pekka's first review. v3: Implement suggestions from Pekka's second revie