Re: [PATCH weston 4/4] logind: fix PropertiesChanged parser

2015-01-16 Thread Bryce Harrington
On Tue, Dec 30, 2014 at 02:33:23PM +0100, David Herrmann wrote: > The current parser directly reads a BOOLEAN on the PropertiesChanged > signal for 'Active' properties. However, all property-values are packed in > a VARIANT, otherwise, we wouldn't know the type. Fix the parser to recurse > into the

Re: [PATCH weston 4/4] logind: fix PropertiesChanged parser

2015-01-06 Thread nerdopolis
On Tuesday, December 30, 2014 02:33:23 PM David Herrmann wrote: > The current parser directly reads a BOOLEAN on the PropertiesChanged > signal for 'Active' properties. However, all property-values are packed in > a VARIANT, otherwise, we wouldn't know the type. Fix the parser to recurse > into the

[PATCH weston 4/4] logind: fix PropertiesChanged parser

2014-12-30 Thread David Herrmann
The current parser directly reads a BOOLEAN on the PropertiesChanged signal for 'Active' properties. However, all property-values are packed in a VARIANT, otherwise, we wouldn't know the type. Fix the parser to recurse into the variant before reading the boolean. To avoid such bugs in the future,