Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-20 Thread Jonas Ådahl
On Wed, May 20, 2015 at 12:32:46PM -0500, Derek Foreman wrote: > Thanks for taking a look! > > On 20/05/15 05:04 AM, Jonas Ådahl wrote: > > On Tue, May 05, 2015 at 03:01:54PM -0500, Derek Foreman wrote: > >> Some devices (power buttons, acpi video bus driver) are considered > >> keyboards but you

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-20 Thread Derek Foreman
Thanks for taking a look! On 20/05/15 05:04 AM, Jonas Ådahl wrote: > On Tue, May 05, 2015 at 03:01:54PM -0500, Derek Foreman wrote: >> Some devices (power buttons, acpi video bus driver) are considered >> keyboards but you can't type with them. >> >> As of libinput 0.15 we can query a keyboard to

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-20 Thread Jonas Ådahl
On Tue, May 05, 2015 at 03:01:54PM -0500, Derek Foreman wrote: > Some devices (power buttons, acpi video bus driver) are considered > keyboards but you can't type with them. > > As of libinput 0.15 we can query a keyboard to see which key events it > can generate. We use this to detect if a keybo

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-06 Thread Bill Spitzak
On 05/06/2015 09:24 AM, Derek Foreman wrote: On 05/05/15 03:59 PM, Bill Spitzak wrote: It sure seems like it would be better to just provide the list of available keys to the client programs, and let them make up their own categories of device types. I think desktop-shell is still going to w

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-06 Thread Derek Foreman
On 05/05/15 03:59 PM, Bill Spitzak wrote: > It sure seems like it would be better to just provide the list of > available keys to the client programs, and let them make up their own > categories of device types. I think desktop-shell is still going to want this information, regardless of whether w

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-05 Thread Bill Spitzak
It sure seems like it would be better to just provide the list of available keys to the client programs, and let them make up their own categories of device types. I'm not sure if requiring every Latin letter is a good test for a keyboard either. Aren't there some foreign layouts that omit som

[PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-05 Thread Derek Foreman
Some devices (power buttons, acpi video bus driver) are considered keyboards but you can't type with them. As of libinput 0.15 we can query a keyboard to see which key events it can generate. We use this to detect if a keyboard can type letters or digits. The wayland protocol doesn't propagate t