Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-21 Thread Guido Günther
Hi, On Fri, Jul 20, 2018 at 11:10:29PM +0200, Guido Günther wrote: > Hi, > On Fri, Jul 13, 2018 at 05:43:50PM +0200, Guido Günther wrote: > > Hi, > > On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > > > No need to write libdrm driver specific code for each supported > > > d

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-20 Thread Guido Günther
Hi, On Fri, Jul 13, 2018 at 05:43:50PM +0200, Guido Günther wrote: > Hi, > On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > > No need to write libdrm driver specific code for each supported > > driver, we can just let GBM call the right one for us now. > > This one breaks

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-13 Thread Daniel Stone
Hi Emilio, On Thu, 12 Jul 2018 at 12:46, Emilio Pozuelo Monfort wrote: > @@ -343,17 +143,16 @@ fill_content(struct buffer *my_buf, uint64_t modifier) > } > else if (modifier == DRM_FORMAT_MOD_LINEAR) { > uint8_t *pix8; > -

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-13 Thread Guido Günther
Hi, On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. This one breaks NV12 on intel when using rootston as compositor for me. $ ./weston-simple-dmab

[PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-12 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- v4: now with working NV12, (thanks Daniel!). clients/simple-dmabuf-drm.c | 411 configure.ac