Re: [PATCH weston 2/6] weston: Allow relative paths for modules

2013-04-26 Thread Quentin Glidic
On 23/04/2013 17:10, Bill Spitzak wrote: This disallows any subdirectories in MODULEDIR. Is this ok? Good question. An alternative would be to use the name unchanged if it starts with either '/' or '.' so the user can type "./foo" to get a file in the current directory. I’ll go this way, i

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

2013-04-26 Thread Quentin Glidic
On 26/04/2013 11:21, Pekka Paalanen wrote: Any specific use case, like tests? I guess I should read the following patches to find out, but that would be nice to tell in the commit message. Mostly tests and in-tree launch, to test a WIP module. -- Quentin “Sardem FF7” Glidic __

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

2013-04-26 Thread Pekka Paalanen
On Tue, 23 Apr 2013 17:16:48 +0200 John Kåre Alsaker wrote: > You should drop the code changes since they already allow relative paths. > You just changed it to only allow base filenames. Paths relative to what? Looks like there is a difference. > On Tue, Apr 23, 2013 at 2:54 PM, Quentin Glidic

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

2013-04-23 Thread John Kåre Alsaker
You should drop the code changes since they already allow relative paths. You just changed it to only allow base filenames. On Tue, Apr 23, 2013 at 2:54 PM, Quentin Glidic < sardemff7+wayl...@sardemff7.net> wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > man/weston.man

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

2013-04-23 Thread Bill Spitzak
On 04/23/2013 05:54 AM, Quentin Glidic wrote: From: Quentin Glidic - if (name[0] != '/') + if (!strchr(name, '/')) snprintf(path, sizeof path, "%s/%s", MODULEDIR, name); else snprintf(path, sizeof path, "%s", name); This disallows any subd

[PATCH weston 2/6] weston: Allow relative paths for modules

2013-04-23 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- man/weston.man | 4 ++-- src/compositor.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/weston.man b/man/weston.man index a25e619..97db3c8 100644 --- a/man/weston.man +++ b/man/weston.man @@ -102,7 +102,7 @@ L