Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-03-16 Thread Scott Moreau
I picked this one up for gh next, since a lot of people were having a problem with this. Animations stalling, especially. - Scott On Wed, Feb 13, 2013 at 7:06 AM, Ander Conselvan de Oliveira wrote: > The page flip event timestamps comes from the monotonic clock, while > idle_repaint() gets the t

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-19 Thread Bill Spitzak
On 02/19/2013 03:16 AM, Pekka Paalanen wrote: http://blog.fishsoup.net/2012/11/28/avoiding-jitter-in-composited-frame-display/ That is really interesting but I think his first solution is what is needed, combined with multiple buffering, which in Wayland is done by the client. In this diag

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-19 Thread Pekka Paalanen
On Tue, 19 Feb 2013 12:17:48 +0200 Ander Conselvan de Oliveira wrote: > On 02/15/2013 10:27 AM, Pekka Paalanen wrote: > > On Thu, 14 Feb 2013 11:51:15 -0500 > > Kristian Høgsberg wrote: > > > >> On Wed, Feb 13, 2013 at 04:06:38PM +0200, Ander Conselvan de Oliveira > >> wrote: > >>> The page fli

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-19 Thread Daniel Stone
Hi, On 19 February 2013 10:17, Ander Conselvan de Oliveira wrote: > That's a tricky one. I agree that the timestamp of a frame callback does > not represent the moment the last attached buffer reached the screen. But > the timestamp is that of the latest completed flip. > > The protocol descript

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-19 Thread Ander Conselvan de Oliveira
On 02/15/2013 10:27 AM, Pekka Paalanen wrote: On Thu, 14 Feb 2013 11:51:15 -0500 Kristian Høgsberg wrote: On Wed, Feb 13, 2013 at 04:06:38PM +0200, Ander Conselvan de Oliveira wrote: The page flip event timestamps comes from the monotonic clock, while idle_repaint() gets the time with gettime

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-15 Thread Pekka Paalanen
On Thu, 14 Feb 2013 11:51:15 -0500 Kristian Høgsberg wrote: > On Wed, Feb 13, 2013 at 04:06:38PM +0200, Ander Conselvan de Oliveira wrote: > > The page flip event timestamps comes from the monotonic clock, while > > idle_repaint() gets the time with gettimeofday(). That leads to > > inconsistent

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-14 Thread Kristian Høgsberg
On Wed, Feb 13, 2013 at 04:06:38PM +0200, Ander Conselvan de Oliveira wrote: > The page flip event timestamps comes from the monotonic clock, while > idle_repaint() gets the time with gettimeofday(). That leads to > inconsistent timestamps on the frame callbacks. > > Fix this by making the drm bac

[PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-02-13 Thread Ander Conselvan de Oliveira
The page flip event timestamps comes from the monotonic clock, while idle_repaint() gets the time with gettimeofday(). That leads to inconsistent timestamps on the frame callbacks. Fix this by making the drm backend page flip to the current buffer and call weston_output_finish_frame() with the pag