Re: [PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

2015-11-30 Thread Derek Foreman
On 27/11/15 04:20 AM, Pekka Paalanen wrote: > On Wed, 18 Nov 2015 16:32:33 -0600 Derek Foreman > wrote: > >> We've been setting up the viewport by moving the start pointer of >> the draw buffer, but later when we want to post damage in buffer >> co-ordinates we'll need to keep track of the x,y of

Re: [PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

2015-11-27 Thread Pekka Paalanen
On Wed, 18 Nov 2015 16:32:33 -0600 Derek Foreman wrote: > We've been setting up the viewport by moving the start pointer of the > draw buffer, but later when we want to post damage in buffer co-ordinates > we'll need to keep track of the x,y offsets anyway. > > Signed-off-by: Derek Foreman > --

Re: [PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

2015-11-19 Thread Bill Spitzak
It is not clear if this is changing anything other than the printf statement, but it makes sense as that is not printing anything about where the origin was moved. I think however the program was broken before. This fix has nothing to do with the transition to buffer damage and is required to prin

Re: [PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

2015-11-19 Thread Derek Foreman
On 18/11/15 07:31 PM, Bill Spitzak wrote: > You sure this has to change? If I'm posting damage in buffer co-ordinates, I need to know what buffer co-ordinates to use. Currently, the code moves the *data pointer and does its drawing as if everything is still at 0,0. ie) if we set a buffer viewpor

Re: [PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

2015-11-18 Thread Bill Spitzak
You sure this has to change? On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman wrote: > We've been setting up the viewport by moving the start pointer of the > draw buffer, but later when we want to post damage in buffer co-ordinates > we'll need to keep track of the x,y offsets anyway. > > Signed-

[PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

2015-11-18 Thread Derek Foreman
We've been setting up the viewport by moving the start pointer of the draw buffer, but later when we want to post damage in buffer co-ordinates we'll need to keep track of the x,y offsets anyway. Signed-off-by: Derek Foreman --- clients/simple-damage.c | 58 +-