RE: [PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

2018-03-20 Thread Ucan, Emre (ADITG/ESB)
Hi Daniel, > -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Dienstag, 20. März 2018 15:48 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston 1/7] compositor-drm: remove superfluos > g

Re: [PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

2018-03-20 Thread Daniel Stone
Hi Emre, On 20 March 2018 at 14:28, Emre Ucan wrote: > drm_output_get_disable_state function returns > a duplicated output_state object. > > Here we are creating the object, but we are > never using it. Therefore, it is safe to remove. > > (Found by clang source code analyzer) It's subtle, but w

[PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

2018-03-20 Thread Emre Ucan
drm_output_get_disable_state function returns a duplicated output_state object. Here we are creating the object, but we are never using it. Therefore, it is safe to remove. (Found by clang source code analyzer) Signed-off-by: Emre Ucan --- libweston/compositor-drm.c | 1 - 1 file changed, 1 de