Hi,
sorry to come to this after it has already landed. I have some comments
here. It's mostly just clean-ups and simplifications, though.
On Fri, 20 Mar 2015 15:26:50 +0100
Jonny Lamb wrote:
> Reviewed-by: Derek Foreman
> Reviewed-by: Bryce Harrington
> ---
> src/compositor-drm.c | 13 +
Reviewed-by: Derek Foreman
Reviewed-by: Bryce Harrington
---
src/compositor-drm.c | 13 ++-
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 20 +--
src/compositor-x11.c | 11 +-
src/gl-renderer.c| 90 ++--
s
Reviewed-by: Derek Foreman
---
src/compositor-drm.c | 13 ++-
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 20 +--
src/compositor-x11.c | 11 +-
src/gl-renderer.c| 90 ++--
src/gl-renderer.h| 6 ++
Hi,
On 25 February 2015 at 12:42, Jonny Lamb wrote:
> +/** Checks whether a client extension or fallbacks are supported
> + *
> + * \param ec The weston compositor
> + * \param extension_suffix The EGL client extension suffix
> + * \return Negative if not supported, otherwise positive
> + *
> + *
Series looks good to me now.
Reviewed-by: Derek Foreman
On 25/02/15 06:42 AM, Jonny Lamb wrote:
> ---
> src/compositor-drm.c | 13 +-
> src/compositor-fbdev.c | 2 +-
> src/compositor-wayland.c | 20 +++--
> src/compositor-x11.c | 11 -
> src/gl-renderer.c| 10
---
src/compositor-drm.c | 13 +-
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 20 +++--
src/compositor-x11.c | 11 -
src/gl-renderer.c| 109 +--
src/gl-renderer.h| 6 ++-
6 files changed, 151 ins
Il 23/02/2015 18:44, Derek Foreman ha scritto:
- if (gl_renderer->create(&compositor->base, EGL_DEFAULT_DISPLAY,
+ if (gl_renderer->create(&compositor->base, 0,
EGL_DEFAULT_DISPLAY,
gl_renderer->opaque_attribs,
Very cool, comments below.
On 17/02/15 09:48 AM, Jonny Lamb wrote:
> ---
> src/compositor-drm.c | 14 -
> src/compositor-fbdev.c | 2 +-
> src/compositor-wayland.c | 21 +++--
> src/compositor-x11.c | 14 -
> src/gl-renderer.c| 79
>
---
src/compositor-drm.c | 14 -
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 21 +++--
src/compositor-x11.c | 14 -
src/gl-renderer.c| 79 ++--
src/gl-renderer.h| 6 +++-
6 files changed,
