Re: [PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

2013-04-01 Thread Kristian Høgsberg
On Thu, Mar 28, 2013 at 08:28:27PM +0100, Jonas Ådahl wrote: > On Thu, Mar 28, 2013 at 7:48 PM, Rob Bradford > wrote: > > From: Rob Bradford > > > > If an unknown id is deleted then the lookup in the map will return NULL and > > so we should avoid dereferencing that. > > Hi Rob, > > I think th

Re: [PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

2013-03-28 Thread Jason Ekstrand
On Mar 28, 2013 2:29 PM, "Jonas Ådahl" wrote: > > On Thu, Mar 28, 2013 at 7:48 PM, Rob Bradford wrote: > > From: Rob Bradford > > > > If an unknown id is deleted then the lookup in the map will return NULL and > > so we should avoid dereferencing that. > > Hi Rob, > > I think the patch looks goo

Re: [PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

2013-03-28 Thread Jonas Ådahl
On Thu, Mar 28, 2013 at 7:48 PM, Rob Bradford wrote: > From: Rob Bradford > > If an unknown id is deleted then the lookup in the map will return NULL and > so we should avoid dereferencing that. Hi Rob, I think the patch looks good, but I have one comment below. Thanks, Jonas > --- > src/way

[PATCH weston 1/2] wayland-client: Avoid null dereference when handling deletion

2013-03-28 Thread Rob Bradford
From: Rob Bradford If an unknown id is deleted then the lookup in the map will return NULL and so we should avoid dereferencing that. --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 0873835..e8d3240 10