Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-17 Thread Emilio Pozuelo Monfort
On 12/02/14 15:55, Jasper St. Pierre wrote: > What reschedules the frame being drawn when focused is gained / lost, then? I'm not sure what reschedules it, but it does happen: twice when the window is focused, twice when it is unfocused (maybe something to optimize, why are we redrawing twice?).

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-12 Thread Bryce W. Harrington
On Wed, Feb 12, 2014 at 09:08:51AM +0100, Emilio Pozuelo Monfort wrote: > On 12/02/14 01:04, Bryce W. Harrington wrote: > > (For full disclosure - On one test run against master, I noticed the > > flower changed shape every time it received or lost focus, however I was > > never able to reproduce t

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-12 Thread Jasper St. Pierre
What reschedules the frame being drawn when focused is gained / lost, then? On Wed, Feb 12, 2014 at 3:08 AM, Emilio Pozuelo Monfort wrote: > On 12/02/14 01:04, Bryce W. Harrington wrote: > > (For full disclosure - On one test run against master, I noticed the > > flower changed shape every time

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-12 Thread Emilio Pozuelo Monfort
On 12/02/14 01:04, Bryce W. Harrington wrote: > (For full disclosure - On one test run against master, I noticed the > flower changed shape every time it received or lost focus, however I was > never able to reproduce that behavior even after doing clean rebuilds.) That's precisely what made me fi

Re: [PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-11 Thread Bryce W. Harrington
On Mon, Feb 10, 2014 at 04:52:32PM +0100, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > Clients that need to be redrawn when the focus changes do that by > listening to focus_changed and scheduling a redraw. > > This was causing unnecessary redraws in the clients, as could be

[PATCH weston 1/2] toytoolkit: avoid unnecessary redraws when focus changes

2014-02-10 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Clients that need to be redrawn when the focus changes do that by listening to focus_changed and scheduling a redraw. This was causing unnecessary redraws in the clients, as could be easily seen by changing focus on weston-flower. Signed-off-by: Emilio Pozuelo Monfo