Hi,
On 2 September 2016 at 09:30, Giulio Camuffo wrote:
> 2016-09-02 10:27 GMT+02:00 Olivier Fourdan :
>>> 2016-09-01 11:52 GMT+02:00 Olivier Fourdan :
>>> >> I’m ok with that, but why not updating all three "grab_*" members?
>>> >
>>> > While I think the key itself would be OK, I suspect updatin
2016-09-02 10:27 GMT+02:00 Olivier Fourdan :
> Hi,
>
> - Original Message -
>> 2016-09-01 11:52 GMT+02:00 Olivier Fourdan :
>> > Hi
>> >
>> >> > + keyboard->grab_serial =
>> >> > wl_display_get_serial(compositor->wl_display);
>> >> > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) {
>> >>
Hi,
- Original Message -
> 2016-09-01 11:52 GMT+02:00 Olivier Fourdan :
> > Hi
> >
> >> > + keyboard->grab_serial =
> >> > wl_display_get_serial(compositor->wl_display);
> >> > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) {
> >> > - keyboard->grab_serial =
> >> > -
2016-09-01 11:52 GMT+02:00 Olivier Fourdan :
> Hi
>
>> > + keyboard->grab_serial = wl_display_get_serial(compositor->wl_display);
>> > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) {
>> > - keyboard->grab_serial =
>> > - wl_display_get_serial(compositor->wl_display);
Hi
> > + keyboard->grab_serial = wl_display_get_serial(compositor->wl_display);
> > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) {
> > - keyboard->grab_serial =
> > - wl_display_get_serial(compositor->wl_display);
> > keyboard->grab_time = time;
> >
On 30/06/2016 16:01, Olivier Fourdan wrote:
Other compositors such as mutter update the keyboard serial for both key
press and key release, unlike weston which updates it only on key press.
When dealing with popup windows which require a match in serials, if the
event that caused the popup to be
Hi all,
Small reminder, I don't think I got any review/reply of these two patches...
Cheers,
Olivier
- Original Message -
> Other compositors such as mutter update the keyboard serial for both key
> press and key release, unlike weston which updates it only on key press.
>
> When deali
Other compositors such as mutter update the keyboard serial for both key
press and key release, unlike weston which updates it only on key press.
When dealing with popup windows which require a match in serials, if the
event that caused the popup to be shown is a key release, then the popup
would
