Re: [PATCH weston 04/11] compositor-fbdev: Avoid dereferencing a pointer in freed memory

2013-07-27 Thread Bill Spitzak
On 07/27/2013 02:08 AM, Rob Bradford wrote: On 27 July 2013 00:21, Bill Spitzak wrote: + device = output->device; fbdev_output_destroy(base); Are you sure this does not free the memory that is now at *device? Maybe I missed something - can you point me at the

Re: [PATCH weston 04/11] compositor-fbdev: Avoid dereferencing a pointer in freed memory

2013-07-27 Thread Rob Bradford
On 27 July 2013 00:21, Bill Spitzak wrote: >> + device = output->device; >> fbdev_output_destroy(base); > > > Are you sure this does not free the memory that is now at *device? Maybe I missed something - can you point me at the code which makes you think it does? My

Re: [PATCH weston 04/11] compositor-fbdev: Avoid dereferencing a pointer in freed memory

2013-07-26 Thread Bill Spitzak
On 07/26/2013 08:29 AM, Rob Bradford wrote: From: Rob Bradford + device = output->device; fbdev_output_destroy(base); Are you sure this does not free the memory that is now at *device? ___ wayland-devel mailing list

[PATCH weston 04/11] compositor-fbdev: Avoid dereferencing a pointer in freed memory

2013-07-26 Thread Rob Bradford
From: Rob Bradford fbdev_output_destroy will free the memory passed into in and since we want to pass the device name into fbdev_output_create we need to save this to an intermediate value --- src/compositor-fbdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compo