Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-07-08 Thread Pekka Paalanen
On Tue, 23 Jun 2015 18:19:38 -0700 "Jon A. Cruz" wrote: > > Oh I forgot an item on the placement of comments. > > > On 06/23/2015 04:31 PM, Jon A. Cruz wrote: > > > > Minor doxygen note: the explicit "\brief" is not needed, and the brief > > description should end with a '.' to allow the auto

Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-23 Thread Jon A. Cruz
Oh I forgot an item on the placement of comments. On 06/23/2015 04:31 PM, Jon A. Cruz wrote: > > Minor doxygen note: the explicit "\brief" is not needed, and the brief > description should end with a '.' to allow the auto-brief to pick it up. > > Overall looks good, but missing a few extra man

Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-23 Thread Jon A. Cruz
Minor doxygen note: the explicit "\brief" is not needed, and the brief description should end with a '.' to allow the auto-brief to pick it up. Overall looks good, but missing a few extra management calls. However those seem applicable to patch 4/11. On 06/22/2015 01:02 PM, Giulio Camuffo wrote

[PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-22 Thread Giulio Camuffo
This commit adds three new exported functions: - weston_compositor_create() returns a new weston_compositor instance, initializing it as the now removed weston_compositor_init() did. - weston_compositor_exit(compositor) asks the compositor to tear down by calling the compositor's exit vfunc which i