Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-13 Thread Bryce Harrington
On Wed, May 13, 2015 at 02:49:47PM +0100, Daniel Stone wrote: > Hi, > > On 13 May 2015 at 13:19, Bryce Harrington wrote: > > Thanks both of you for the reviews. I've implemented some of the > > changes you suggested: > > > > * Refactor cairo out of the test client backend code entirely > >b

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-13 Thread Daniel Stone
Hi, On 13 May 2015 at 13:19, Bryce Harrington wrote: > Thanks both of you for the reviews. I've implemented some of the > changes you suggested: > > * Refactor cairo out of the test client backend code entirely >by utilizing the weston test surface structure to carry the >specific data

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-13 Thread Bryce Harrington
On Mon, May 11, 2015 at 03:41:44PM +0300, Pekka Paalanen wrote: > On Sat, 9 May 2015 15:01:13 +0100 > Daniel Stone wrote: > > > Hi Bryce, > > > > On 7 May 2015 at 01:44, Bryce Harrington wrote: > > > This series adds support for implementing test cases that can check > > > rendering output with

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-12 Thread Pekka Paalanen
On Tue, 12 May 2015 10:47:08 +0300 Pekka Paalanen wrote: > On Mon, 11 May 2015 16:07:26 +0100 > Daniel Stone wrote: > > > Hi, > > > > On 11 May 2015 at 13:41, Pekka Paalanen wrote: > > > Did you notice, that 'clientside-screenshot.png' ends up all black, if > > > you do 'make check BACKEND=x1

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-12 Thread Pekka Paalanen
On Mon, 11 May 2015 16:07:26 +0100 Daniel Stone wrote: > Hi, > > On 11 May 2015 at 13:41, Pekka Paalanen wrote: > > Did you notice, that 'clientside-screenshot.png' ends up all black, if > > you do 'make check BACKEND=x11-backend.so'? > > Wonder why it does that, you're not intending to do anyt

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-11 Thread Daniel Stone
Hi, On 11 May 2015 at 13:41, Pekka Paalanen wrote: > Did you notice, that 'clientside-screenshot.png' ends up all black, if > you do 'make check BACKEND=x11-backend.so'? > Wonder why it does that, you're not intending to do anything > backend-specific. Except the server command line arguments? €

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-11 Thread Pekka Paalanen
On Sat, 9 May 2015 15:01:13 +0100 Daniel Stone wrote: > Hi Bryce, > > On 7 May 2015 at 01:44, Bryce Harrington wrote: > > This series adds support for implementing test cases that can check > > rendering output without needing connection to a physical output. It > > utilizes the pixman rendere

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-09 Thread Daniel Stone
Hi Bryce, On 7 May 2015 at 01:44, Bryce Harrington wrote: > This series adds support for implementing test cases that can check > rendering output without needing connection to a physical output. It > utilizes the pixman renderer in the headless backend to generate > screenshots at the request o

[PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-06 Thread Bryce Harrington
This series adds support for implementing test cases that can check rendering output without needing connection to a physical output. It utilizes the pixman renderer in the headless backend to generate screenshots at the request of the test client. The test creates a shm buffer and passes it to t