Re: [PATCH weston] xwm: Fix opaque region system.

2012-11-27 Thread Kristian Høgsberg
On Thu, Nov 22, 2012 at 03:35:13PM -0700, Scott Moreau wrote: > Since surface.commit was introduced, opqaue regions are stored in a pending > variable that isn't used until surface.commit. Xwayland uses the surface > opaque > region as a way to tell weston what region of the surface should be opaq

Re: [PATCH weston] xwm: Fix opaque region system.

2012-11-24 Thread Pekka Paalanen
On Sat, 24 Nov 2012 03:56:25 +1100 Daniel Stone wrote: > Hi Pekka, > > > On 23 November 2012 18:35, Pekka Paalanen wrote: > > > \Weston_surface:opaque is referenced only in the transform_disable() > > path, because we never bothered to write an algorithm for the > > transform_enable() path. A

Re: [PATCH weston] xwm: Fix opaque region system.

2012-11-23 Thread Kristian Høgsberg
On Sat, Nov 24, 2012 at 03:56:25AM +1100, Daniel Stone wrote: > Hi Pekka, > > > On 23 November 2012 18:35, Pekka Paalanen wrote: > > > \Weston_surface:opaque is referenced only in the transform_disable() > > path, because we never bothered to write an algorithm for the > > transform_enable() pa

Re: [PATCH weston] xwm: Fix opaque region system.

2012-11-23 Thread Daniel Stone
Hi Pekka, On 23 November 2012 18:35, Pekka Paalanen wrote: > \Weston_surface:opaque is referenced only in the transform_disable() > path, because we never bothered to write an algorithm for the > transform_enable() path. A pixman region deals with axis-aligned > rectangles, and the conversion f

Re: [PATCH weston] xwm: Fix opaque region system.

2012-11-23 Thread Scott Moreau
Hi Pekka, Thanks for the review and detailed explanation. On Fri, Nov 23, 2012 at 12:35 AM, Pekka Paalanen wrote: > On Thu, 22 Nov 2012 15:35:13 -0700 > Scott Moreau wrote: > > > Since surface.commit was introduced, opqaue regions are stored in a > pending > > variable that isn't used until sur

Re: [PATCH weston] xwm: Fix opaque region system.

2012-11-22 Thread Pekka Paalanen
On Thu, 22 Nov 2012 15:35:13 -0700 Scott Moreau wrote: > Since surface.commit was introduced, opqaue regions are stored in a pending > variable that isn't used until surface.commit. Xwayland uses the surface > opaque > region as a way to tell weston what region of the surface should be opaque. >

[PATCH weston] xwm: Fix opaque region system.

2012-11-22 Thread Scott Moreau
Since surface.commit was introduced, opqaue regions are stored in a pending variable that isn't used until surface.commit. Xwayland uses the surface opaque region as a way to tell weston what region of the surface should be opaque. However when this pending opaque region was introduced, xwm was not