Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-09 Thread Pekka Paalanen
On Fri, 9 May 2014 20:09:43 -0400 "Jasper St. Pierre" wrote: > This requires a bit of insider knowledge: we're planning on > adding a set_window_geometry request to xdg_shell explicitly > override the window geometry rectangle for a surface. I don't > think we've talked about this on the list bef

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-09 Thread Jasper St. Pierre
This requires a bit of insider knowledge: we're planning on adding a set_window_geometry request to xdg_shell explicitly override the window geometry rectangle for a surface. I don't think we've talked about this on the list before. This makes subsurfaces viable for tooltips, with the caveat that

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 11:47:08AM +0300, Pekka Paalanen wrote: > On Tue, 6 May 2014 14:40:53 -0700 > Kristian Høgsberg wrote: > > > On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira > > wrote: > > > From: Ander Conselvan de Oliveira > > > > > > > > > Otherwise it might rece

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Pekka Paalanen
Please always use reply-to-all, you have dropped a lot people from CC. On Wed, 07 May 2014 11:02:56 -0700 Bill Spitzak wrote: > On 05/07/2014 01:47 AM, Pekka Paalanen wrote: > > > It is for normal windows like registered with xdg_shell where > > sub-surfaces are not suitable for tooltips. A sub

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Daniel Stone
On 7 May 2014 20:23, Bill Spitzak wrote: > If a subsurface belongs to a different client than the parent surface, > though, does this mean the child client will get events that have an xy > position relative to the parent surface? As a fundamental design point of the Wayland protocol is that cl

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Bill Spitzak
Sorry, what I meant was the surface id and xy location in events. If a subsurface belongs to a different client than the parent surface, though, does this mean the child client will get events that have an xy position relative to the parent surface? On 05/07/2014 11:05 AM, Jasper St. Pierre w

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Jasper St. Pierre
Events aren't delivered to surfaces. They're delivered to clients. On Wed, May 7, 2014 at 2:02 PM, Bill Spitzak wrote: > On 05/07/2014 01:47 AM, Pekka Paalanen wrote: > > It is for normal windows like registered with xdg_shell where >> sub-surfaces are not suitable for tooltips. A sub-surface

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Bill Spitzak
On 05/07/2014 01:47 AM, Pekka Paalanen wrote: It is for normal windows like registered with xdg_shell where sub-surfaces are not suitable for tooltips. A sub-surface is a part of the window, not another window. A tooltip is not expected to change the window geometry, but a sub-surface does count

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-07 Thread Pekka Paalanen
On Tue, 6 May 2014 14:40:53 -0700 Kristian Høgsberg wrote: > On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira > wrote: > > From: Ander Conselvan de Oliveira > > > > > > Otherwise it might receive touch events. > > I think a better approach is to just hide the tooltip if it

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-06 Thread Kristian Høgsberg
On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Otherwise it might receive touch events. I think a better approach is to just hide the tooltip if it (or the panel) gets touch events. I don't think I agree with Pekka that we ca

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-05 Thread Pekka Paalanen
On Mon, 5 May 2014 17:02:15 +0300 Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Otherwise it might receive touch events. > > https://bugs.freedesktop.org/show_bug.cgi?id=78207 Hi, I added a comment to the bug, as I am not sure the below change implements an expe

[PATCH weston] window.c: Set the input region of the tooltip to empty

2014-05-05 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Otherwise it might receive touch events. https://bugs.freedesktop.org/show_bug.cgi?id=78207 --- clients/window.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/window.c b/clients/window.c index b7febed..f667cdf 100644 --- a/clients/window.c +++ b/