Re: [PATCH weston] weston-launch: Let the user use her real shell

2014-03-06 Thread Jason Ekstrand
Where is the shell coming from? If it's the shell specified in /etc/paswd and if we can guarantee that it doesn't read ~/.profile or similar than it's ok. However, If this is the case, then how is it useful to run with the user's shell? If it is the shell from $SHELL or if it reads ~/.profile an

[PATCH weston] weston-launch: Let the user use her real shell

2014-03-06 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- This patch restores the old behaviour if the user wants to. This keeps /bin/sh around for shells that do not understand -c "weston \"$@\"". src/weston-launch.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH weston] weston-launch: Let the user use her real shell

2014-01-27 Thread Quentin Glidic
Hi, On 24/01/2014 08:33, David Herrmann wrote: weston-launch passes privileged FDs back to weston. I don't think we should allow a user to use their own shell to spawn weston. How can you guarantee the shell does not point to some random binary of the user? This way, they can get access to arbit

Re: [PATCH weston] weston-launch: Let the user use her real shell

2014-01-23 Thread David Herrmann
Hi On Fri, Jan 24, 2014 at 7:13 AM, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > src/weston-launch.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/weston-launch.c b/src/weston-launch.c > index 56e22b1..fd04552

[PATCH weston] weston-launch: Let the user use her real shell

2014-01-23 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- src/weston-launch.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/weston-launch.c b/src/weston-launch.c index 56e22b1..fd04552 100644 --- a/src/weston-launch.c +++ b/src/weston-launch.c @@ -103,6 +103,7