Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-23 Thread Derek Foreman
On 23/01/15 11:16 AM, Bryce Harrington wrote: > On Tue, Jan 20, 2015 at 01:16:26PM -0600, Derek Foreman wrote: >> This also skips the test when running on the headless backend. >> >> Signed-off-by: Derek Foreman > > Reviewed-by: Bryce Harrington > > (But waiting for resolution on daniels' comme

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-23 Thread Bryce Harrington
On Tue, Jan 20, 2015 at 01:16:26PM -0600, Derek Foreman wrote: > This also skips the test when running on the headless backend. > > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington (But waiting for resolution on daniels' comments to pull.) > --- > tests/buffer-count-test.c | 5

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-22 Thread Derek Foreman
On 22/01/15 03:48 PM, Daniel Stone wrote: > Hi, > > On Tuesday, January 20, 2015, Derek Foreman > wrote: > > This also skips the test when running on the headless backend. > > > I like this part! > > > + if (strstr(extensions, "EGL_WL_bind_waylan

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-22 Thread Daniel Stone
Hi, On Tuesday, January 20, 2015, Derek Foreman wrote: > This also skips the test when running on the headless backend. I like this part! > + if (strstr(extensions, "EGL_WL_bind_wayland_display") == NULL) > + skip("Wayland extensions not present.\n"); > But not this part

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-22 Thread Jon A. Cruz
On 01/20/2015 11:16 AM, Derek Foreman wrote: > This also skips the test when running on the headless backend. > > Signed-off-by: Derek Foreman Looks good. One less failure here. Reviewed-by: Jon A. Cruz > --- > tests/buffer-count-test.c | 5 + > 1 file changed, 5 insertions(+) > > diff

[PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-20 Thread Derek Foreman
This also skips the test when running on the headless backend. Signed-off-by: Derek Foreman --- tests/buffer-count-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/buffer-count-test.c b/tests/buffer-count-test.c index 5985a9e..3dd6e1a 100644 --- a/tests/buffer-count-test.c +